From: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
To: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: Heikki Linnakangas <heikki@enterprisedb.com>
Cc: PostgreSQL-patches <pgsql-patches@postgresql.org>
Subject: Re: page macros cleanup (ver 04)
Date: Tue, 08 Jul 2008 21:28:27 +0200
Message-ID: <4873BFDB.7020702@sun.com> (raw)
In-Reply-To: <486E138F.4060900@sun.com>
References: <48529B83.9010907@sun.com>
<2e78013d0807030450m4cab60d0jd99d1acce59fae56@mail.gmail.com>
<486DD1D1.50604@sun.com>
<2e78013d0807040150w393ad72codaf06a6ac12a83ce@mail.gmail.com>
<486DF644.4070604@enterprisedb.com>
<2e78013d0807040350m3b2913cfkceaa70d8f9d697c2@mail.gmail.com>
<486E01B0.9050100@enterprisedb.com>
<2e78013d0807040404q5ff7f7faq9f87a39e0f0552fa@mail.gmail.com>
<486E138F.4060900@sun.com>
Pavan, Heikki,
Is it OK now or do you have any comments?
Thanks Zdenek
Zdenek Kotala napsal(a):
> Pavan Deolasee napsal(a):
>> On Fri, Jul 4, 2008 at 4:25 PM, Heikki Linnakangas
>> <heikki@enterprisedb.com> wrote:
>>>
>>> No, there's a itemsz = MAXALIGN(itemsz) call before the check against
>>> HashMaxItemSize.
>>>
>>
>> Ah, right. Still should we just not MAXALIGN_DOWN the Max size to
>> reflect the practical limit on the itemsz ? It's more academical
>> though, so not a big deal.
>
> Finally I use following formula:
>
> #define HashMaxItemSize(page) \
> MAXALIGN_DOWN(PageGetPageSize(page) - \
> ( SizeOfPageHeaderData + sizeof(ItemIdData) ) - \
> MAXALIGN(sizeof(HashPageOpaqueData)) )
>
>
> I did not replace PageGetPageSize(page), because other *MaxItemSize has
> same interface.
>
> Revised patch is attached.
>
> Zdenek
>
>
> ------------------------------------------------------------------------
>
>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: Zdenek.Kotala@Sun.COM, pavan.deolasee@gmail.com, heikki@enterprisedb.com
Subject: Re: page macros cleanup (ver 04)
In-Reply-To: <4873BFDB.7020702@sun.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox