pg.ddx.io  pgsql-patches@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki@enterprisedb.com>
To: Gregory Stark <stark@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] VACUUM Improvements - WIP Patch
Date: Tue, 15 Jul 2008 11:23:50 +0300
Message-ID: <487C5E96.1020907@enterprisedb.com> (raw)
In-Reply-To: <87bq10nx2p.fsf@oxford.xeocode.com>
References: <2e78013d0806092232h6ca15ffejcbcd24e88401308f@mail.gmail.com>
	<21751.1215883933@sss.pgh.pa.us>
	<2e78013d0807132050j16cdc558s4dc3f889371a937d@mail.gmail.com>
	<8741.1216049025@sss.pgh.pa.us>
	<87hcasmloh.fsf@oxford.xeocode.com>
	<28739.1216058100@sss.pgh.pa.us>
	<87bq10nx2p.fsf@oxford.xeocode.com>

Gregory Stark wrote:
> I thought
> we only pruned when we wanted to insert a new tuple and found not enough
> space.

Nope, we prune on any access to the page, if the page is "full enough", 
and the pd_prune_xid field suggests that there is something to prune.

The problem with only pruning on inserts is that by the time we get to 
heap_insert/heap_update, we're already holding a pin on the page, which 
prevents us from acquiring the vacuum lock.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com



view thread (17+ messages)  latest in thread

Message-ID: <487C5E96.1020907@enterprisedb.com>
Permalink:  ../487C5E96.1020907@enterprisedb.com/
Also on:    postgresql.org/message-id/487C5E96.1020907@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-patches@postgresql.org
  Cc: heikki@enterprisedb.com, stark@enterprisedb.com, tgl@sss.pgh.pa.us, pavan.deolasee@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: [PATCHES] VACUUM Improvements - WIP Patch
  In-Reply-To: <487C5E96.1020907@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox