From: Teodor Sigaev <teodor@sigaev.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Oleg Bartunov <oleg@sai.msu.su>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] GIN improvements
Date: Wed, 23 Jul 2008 17:39:49 +0400
Message-ID: <488734A5.9030503@sigaev.ru> (raw)
In-Reply-To: <2818.1216753264@sss.pgh.pa.us>
References: <483FD205.4090904@sigaev.ru>
<486BC501.6060605@sigaev.ru>
<27880.1215810535@sss.pgh.pa.us>
<487A6E0C.3090600@sigaev.ru>
<29437.1216742605@sss.pgh.pa.us>
<48861758.4070507@sigaev.ru>
<1636.1216749010@sss.pgh.pa.us>
<488625E8.4070203@sigaev.ru>
<2818.1216753264@sss.pgh.pa.us>
> once, for regular VACUUM I think you really have to call it within
> each bulkdelete operation.
Exactly what I did in last patch.
> There's probably no point in optimizing
> it away in VACUUM FULL either, since surely it'll be fast to call
> index_cleanup when there's nothing in the pending list?
Sure, with empty pending list insertcleanup will just lock/unlock metapage.
> Yeah, I was going to complain about that next :-). Autovacuum isn't
> going to trigger as a result of INSERT operations; somehow we have
> to teach it what to do for GIN indexes. I remember we discussed this
> at PGCon but I don't think we decided exactly what to do...
So, may be we just move insertcleanup call to ginbulkdelete/ginvacuumcleanup
but leave aminsertcleanup field in pg_proc for a future.
> I've already made a number of changes to the patch; let me keep working
> on it and send it back to you later.
ok
--
Teodor Sigaev E-mail: teodor@sigaev.ru
WWW: http://www.sigaev.ru/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: teodor@sigaev.ru, tgl@sss.pgh.pa.us, oleg@sai.msu.su, pgsql-hackers@postgresql.org
Subject: Re: [PATCHES] GIN improvements
In-Reply-To: <488734A5.9030503@sigaev.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox