From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Karl Schnaitter <karlsch@soe.ucsc.edu>
Cc: pgsql-patches@postgresql.org
Subject: Re: fixing bug in combocid.c
Date: Mon, 01 Sep 2008 21:55:32 +0300
Message-ID: <48BC3AA4.7060804@enterprisedb.com> (raw)
In-Reply-To: <48B87164.4050802@soe.ucsc.edu>
References: <48B87164.4050802@soe.ucsc.edu>
Karl Schnaitter wrote:
> This patch is for a bug in backend/utils/time/combocid.c.
>
> In HeapTupleHeaderAdjustCmax, the code makes the incorrect assumption
> that the raw command id corresponds to cmin, when the raw command id can
> in fact be a combo cid. It needs to be fixed to call
> HeapTupleHeaderGetCmin to get cmin. That's all there is to my patch, but
> read on for more details.
Yep. Patch committed.
Thanks for the report!
> This is my first patch; I hope I did it right!
You did well :-). No need to tar or gzip small patches like that, though.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: heikki.linnakangas@enterprisedb.com, karlsch@soe.ucsc.edu
Subject: Re: fixing bug in combocid.c
In-Reply-To: <48BC3AA4.7060804@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox