From: Magnus Hagander <magnus@hagander.net>
To: Bruce Momjian <bruce@momjian.us>
Cc: Martin Zaun <Martin.Zaun@Sun.COM>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Heikki Linnakangas <heikki@enterprisedb.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Dave Page <dpage@pgadmin.org>
Cc: List pgsql-patches <pgsql-patches@postgresql.org>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] odd output in restore mode
Date: Mon, 15 Dec 2008 23:08:14 +0100
Message-ID: <4946D54E.4060406@hagander.net> (raw)
In-Reply-To: <200812152115.mBFLFpV20891@momjian.us>
References: <200812152115.mBFLFpV20891@momjian.us>
Bruce Momjian wrote:
> Martin Zaun wrote:
>> 4. Issue: missing break in switch, silent override of '-l' argument?
>>
>> This behaviour has been in there before and is not addresses by the
>> patch: The user-selected Win32 "mklink" command mode is never applied
>> due to a missing 'break' in CustomizableInitialize():
>>
>> switch (restoreCommandType)
>> {
>> case RESTORE_COMMAND_WIN32_MKLINK:
>> SET_RESTORE_COMMAND("mklink", WALFilePath, xlogFilePath);
>> case RESTORE_COMMAND_WIN32_COPY:
>> SET_RESTORE_COMMAND("copy", WALFilePath, xlogFilePath);
>> break;
>
> I have added the missing 'break' to CVS HEAD; thanks.
Why no backpatch to 8.3? Seems like a clear bugfix to me.
//Magnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: magnus@hagander.net, bruce@momjian.us, Martin.Zaun@Sun.COM, simon@2ndquadrant.com, heikki@enterprisedb.com, andrew@dunslane.net, dpage@pgadmin.org, pgsql-hackers@postgresql.org
Subject: Re: [PATCHES] odd output in restore mode
In-Reply-To: <4946D54E.4060406@hagander.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox