From: Bryce Nesbitt <bryce2@obviously.com>
To: Pgsql Hackers <pgsql-hackers@postgresql.org>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Jaime Casanova <jcasanov@systemguards.com.ec>
Subject: Re: New pg_dump patch, --no-stats flag, disables sending to statistics collector
Date: Tue, 20 Jan 2009 14:15:44 -0800
Message-ID: <49764D10.4000009@obviously.com> (raw)
In-Reply-To: <200901202154.n0KLsmL11525@momjian.us>
References: <200901202154.n0KLsmL11525@momjian.us>
Bruce Momjian wrote:
> Jaime Casanova wrote:
>
>> i haven't looked at the patch nor it's functional use... but from the
>> top of my head jumps a question: is there a reason to not make this
>> the default behaviour?
>>
> If this is a generally desired feature (and I question that), I think we
> need a more general solution.
>
I'm not a big fan of flags, preferring good defaults. But I was not
bold enough to suggest this as a new default, as someone would probably
want the opposite flag. If you're measuring total server load (rather
than analyzing an application), you may want to see pg_dump activity.
As for a "general" solution: one could add the ability to inject
arbitrary sql just prior to a dump run. That would let someone roll
their own by injecting "SET stats_block_level = false", or make any
other arbitrary settings changes.
Or one might slice the statistics collector by role or user (so your
'backup' role would keep a separate tally).
On the other hand, the flag's advantage is simplicity and directness.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: bryce2@obviously.com, pgsql-hackers@postgresql.org, bruce@momjian.us, jcasanov@systemguards.com.ec
Subject: Re: New pg_dump patch, --no-stats flag, disables sending to statistics collector
In-Reply-To: <49764D10.4000009@obviously.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox