pg.ddx.io  pgsql-patches@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Ryan Bradetich <rbradetich@gmail.com>
To: pgsql-patches <pgsql-patches@postgresql.org>
Subject: Re: [PgFoundry] Unsigned Data Types [1 of 2]
Date: Mon, 15 Sep 2008 19:45:25 -0700
Message-ID: <e739902b0809151945v16fe3af0pe78b2cb133d94c91@mail.gmail.com> (raw)
In-Reply-To: <e739902b0809150813x7e3e2af6s4174197efd5d3070@mail.gmail.com>
References: <e739902b0808311335l1ad5d425r2704429c386f2f88@mail.gmail.com>
	<3073cc9b0809061341q5c747488i85491e4c8e2420ba@mail.gmail.com>
	<3073cc9b0809062330o62fd74dax74b1730cedc0fbb9@mail.gmail.com>
	<e739902b0809082008p6c694a20ufd526d1ce5d46750@mail.gmail.com>
	<3073cc9b0809082254g789a7f14x45e9d416925b1057@mail.gmail.com>
	<e739902b0809082325s69c21814mbc0dc8dfd6ebfec6@mail.gmail.com>
	<22555.1220962305@sss.pgh.pa.us>
	<e739902b0809090814j55a75d6dm213432b87f4b0c5f@mail.gmail.com>
	<e739902b0809100803jc35798fga19b3e77019422fa@mail.gmail.com>
	<e739902b0809150813x7e3e2af6s4174197efd5d3070@mail.gmail.com>

Message Resend.

I forgot to spit the attachments so they did not make it through the list.

Patch 1 of 2 : Base uint type.
Patch 2 of 2 : Regression tests.

- Ryan


On Mon, Sep 15, 2008 at 8:13 AM, Ryan Bradetich <rbradetich@gmail.com> wrote:
> Hello Jaime,
>
> I have the code and regression tests updated to solve the problems you initially
> discovered.  After code reading, stepping through with the debugger, and
> help from RhodiumToad on irc I was able to implement new restrict
> selective estimation
> functions for the uint4 vs int4 data types.  The uint1 vs int4 and
> uint2 vs int4 data
> types did not require a custom restrict selective estimation function.
>
> Here is an updated base and tests tar packages with these changes in place.  I
> still have better code comments on my TODO list.  I wanted to get
> updated code out
> to see if there are other problems the unsigned data type fails to
> address properly.
>
> I will work on better commenting the code tonight and tomorrow.
>
> Thanks again for your review and testing!
>
> - Ryan
>

Attachments:

  uint-base-v2.tar.bz2 (application/x-bzip2, 8.2K) download

view thread (26+ messages)  latest in thread

Message-ID: <e739902b0809151945v16fe3af0pe78b2cb133d94c91@mail.gmail.com>
Permalink:  ../e739902b0809151945v16fe3af0pe78b2cb133d94c91@mail.gmail.com/
Also on:    postgresql.org/message-id/e739902b0809151945v16fe3af0pe78b2cb133d94c91@mail.gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-patches@postgresql.org
  Cc: rbradetich@gmail.com
  Subject: Re: [PgFoundry] Unsigned Data Types [1 of 2]
  In-Reply-To: <e739902b0809151945v16fe3af0pe78b2cb133d94c91@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox