From: Simon Riggs <simon@2ndquadrant.com>
To: 'Tom Lane' <tgl@sss.pgh.pa.us>
Cc: 'Neil Conway' <neilc@samurai.com>
Cc: josh@agliodbs.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PERFORM] WAL Optimisation - configuration and usage
Date: Mon, 8 Mar 2004 23:28:25 -0000
Message-ID: <004601c40565$0e848c60$f3bd87d9@LaptopDellXP> (raw)
In-Reply-To: <19294.1078357583@sss.pgh.pa.us>
>Tom Lane
> "Simon Riggs" <simon@2ndquadrant.com> writes:
> > The behaviour I wish to add is:
> > Keep wal_debug as a value between 0 and 16.
> > If =0 then no debug output (default).
> > Use following bitmasks against the value
> > Mask 1 = XLOG Checkpoints get logged
> > Mask 2 = Archive API calls get logged
> > Mask 4 = Transaction - commits get logged
> > Mask 8 = Flush & INSERTs get logged
>
> I see no value in reverting Neil's change. The above looks way too
much
> like old-line assembler-programmer thinking to me, anyway. Why not
> invent a separate, appropriately named boolean variable for each thing
> you want to control? Even C programmers manage to avoid doing the
sort
> of mental arithmetic that the above would force onto DBAs.
>
> As for whether it should be #ifdef'd or not, I'd have no objection to
> turning WAL_DEBUG on by default in pg_config_manual.h for the duration
> of PITR development. One should not however confuse short-term
> debugging needs with features that the average user is going to need
> indefinitely. (It was not too long ago that there was still debugging
> code for btree index building in there, for crissakes.)
...erm, I guess you didn't like that one then? ;}
> As for whether it should be #ifdef'd or not, I'd have no objection to
> turning WAL_DEBUG on by default in pg_config_manual.h for the duration
> of PITR development.
Yes OK, thank you.
> Why not
> invent a separate, appropriately named boolean variable for each thing
> you want to control?
Yes, OK, will do.
Best Regards, Simon Riggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: simon@2ndquadrant.com, tgl@sss.pgh.pa.us, neilc@samurai.com, josh@agliodbs.com, pgsql-hackers@postgresql.org
Subject: Re: [PERFORM] WAL Optimisation - configuration and usage
In-Reply-To: <004601c40565$0e848c60$f3bd87d9@LaptopDellXP>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox