From: Simon Riggs <simon@2ndquadrant.com>
To: Bill Moran <wmoran@collaborativefusion.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-performance@postgresql.org
Subject: Re: Advice on selecting good values for work_mem?
Date: Thu, 28 Dec 2006 13:19:44 +0000
Message-ID: <1167311984.3633.87.camel@silverbirch.site> (raw)
In-Reply-To: <20061218161805.04699b10.wmoran@collaborativefusion.com>
References: <20061207113531.98095b27.wmoran@collaborativefusion.com>
<16388.1165510978@sss.pgh.pa.us>
<20061218161805.04699b10.wmoran@collaborativefusion.com>
On Mon, 2006-12-18 at 16:18 -0500, Bill Moran wrote:
> In response to Tom Lane <tgl@sss.pgh.pa.us>:
>
> > Bill Moran <wmoran@collaborativefusion.com> writes:
> > > Does the creation of a temp file trigger any logging?
> >
> > No; but it wouldn't be hard to add some if you wanted. I'd do it at
> > deletion, not creation, so you could log the size the file reached.
> > See FileClose() in src/backend/storage/file/fd.c.
>
> Is this along the lines of what you were thinking? Is this acceptable
> to get pulled into the tree (maintaining local patches sucks ;) I've
> only been using this patch a day and I'm already giddy about how much
> it helps tuning work memory sizes ...
You need to submit to patches, not here. Patch looks right, but needs
some extra things:
- activate based upon a GUC called trace_temp_files (?) to be added in
src/backend/utils/misc/guc.c - using a temp file is a problem only in
the eye of the beholder, so let the admin decide whether to show the
info or not (default not)
- level LOG not WARNING, with no hint message (?)
- message should be something like "temp file: size %s path: %s" so we
can see where the file was created (there is another todo about creating
temp files in different locations)
- add a trace point also for those who don't want to enable a parameter,
described here
http://www.postgresql.org/docs/8.2/static/dynamic-trace.html
e.g. PGTRACE1(temp__file__cleanup, filestats.st_size)
--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: simon@2ndquadrant.com, wmoran@collaborativefusion.com, tgl@sss.pgh.pa.us
Subject: Re: Advice on selecting good values for work_mem?
In-Reply-To: <1167311984.3633.87.camel@silverbirch.site>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox