From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Treat <xzilla@users.sourceforge.net>
Cc: pgsql-performance@postgresql.org, Alvaro Herrera <alvherre@commandprompt.com>
Subject: Re: Re: [HACKERS] [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search
Date: Sat, 26 Apr 2008 13:26:44 -0400
Message-ID: <13180.1209230804@sss.pgh.pa.us> (raw)
In-Reply-To: <200804260910.55203.xzilla@users.sourceforge.net>
References: <20080317021856.0D2D37558DC@cvs.postgresql.org>
<200804251724.48705.xzilla@users.sourceforge.net>
<865.1209159179@sss.pgh.pa.us>
<200804260910.55203.xzilla@users.sourceforge.net>
Robert Treat <xzilla@users.sourceforge.net> writes:
> On Friday 25 April 2008 17:32, Tom Lane wrote:
>> Robert Treat <xzilla@users.sourceforge.net> writes:
>>> Oddly some dtrace profiling gave me this, which is pretty different, but
>>> certainly doesn't have concerns about TransactionIdIsCurrentTransactionId
>>
>> .... which seems to pretty much destroy your thesis, no?
> How so? Before the patch we bog down for hours, spending 99% of our time in
> TransactionIdIsCurrentTransactionId, after the patch everything performs well
> (really better than before) and we spend so little time in
> TransactionIdIsCurrentTransactionId it barely shows up on the radar.
Oh, you failed to state that the dtrace output was post-patch. You need
to show *pre* patch dtrace output if you want us to think it relevant.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: tgl@sss.pgh.pa.us, xzilla@users.sourceforge.net, alvherre@commandprompt.com
Subject: Re: Re: [HACKERS] [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search
In-Reply-To: <13180.1209230804@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox