pg.ddx.io  pgsql-performance@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: siracusa@mindspring.com
Cc: Postgres Performance <pgsql-performance@postgresql.org>
Subject: Re: Feature request: smarter use of conditional indexes
Date: Sat, 06 Mar 2004 16:06:09 -0500
Message-ID: <18409.1078607169@sss.pgh.pa.us> (raw)
In-Reply-To: <BC6FA413.30DB6%siracusa@mindspring.com>
References: <BC6FA413.30DB6%siracusa@mindspring.com>

John Siracusa <siracusa@mindspring.com> writes:
> So apparently all I can do is find out if it's a null test, but not if it is
> specifically "IS NOT NULL"

No, because once you have determined that the node really IsA NullTest,
you can cast the pointer to (NullTest *) and look at the
NullTest-specific fields.  Think of this as poor man's object-oriented
programming: Node is the supertype of Expr which is the supertype of
NullTest (and a lot of other kinds of nodes, too).

It'd look something like

	if (IsA(predicate, NullTest) &&
	    ((NullTest *) predicate)->nulltesttype == IS_NOT_NULL)
	{
	  /* check to see if arg field matches either side of opclause,
	   * and if so check whether operator is strict ...
	   */
	}

You can find plenty of examples of this programming pattern throughout
the backend.  In fact pred_test_simple_clause is doing exactly this
to check that what it's given is an OpExpr and not some other node type.

			regards, tom lane



view thread (11+ messages)  latest in thread

Message-ID: <18409.1078607169@sss.pgh.pa.us>
Permalink:  ../18409.1078607169@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/18409.1078607169@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-performance@postgresql.org
  Cc: tgl@sss.pgh.pa.us, siracusa@mindspring.com
  Subject: Re: Feature request: smarter use of conditional indexes
  In-Reply-To: <18409.1078607169@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox