pg.ddx.io  pgsql-performance@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Larry Rosenman <ler@lerctr.org>
Cc: John Siracusa <siracusa@mindspring.com>
Cc: Postgres Performance <pgsql-performance@postgresql.org>
Subject: Re: Feature request: smarter use of conditional indexes
Date: Mon, 8 Mar 2004 12:55:36 -0500 (EST)
Message-ID: <200403081755.i28Htau25541@candle.pha.pa.us> (raw)
In-Reply-To: <20141.1078631217@sss.pgh.pa.us>

Tom Lane wrote:
> Larry Rosenman <ler@lerctr.org> writes:
> > Just a suggestion, please use diff -c format, as it makes it easier for
> > the folks who apply the patches to do so.
> 
> That's not just a suggestion ... patches that aren't in diff -c (or at
> least diff -u) format will be rejected out of hand.  Without the context
> lines provided by these formats, applying a patch is an exercise in
> risk-taking, because you can't be certain that you are applying the same
> patch the submitter intended.

Also, when you get 'fuzz' output when applying the patch, you should
review the patch to make sure it appeared in the right place.  That has
gotten me a few times.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073



view thread (11+ messages)

Message-ID: <200403081755.i28Htau25541@candle.pha.pa.us>
Permalink:  ../200403081755.i28Htau25541@candle.pha.pa.us/
Also on:    postgresql.org/message-id/200403081755.i28Htau25541@candle.pha.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-performance@postgresql.org
  Cc: pgman@candle.pha.pa.us, tgl@sss.pgh.pa.us, ler@lerctr.org, siracusa@mindspring.com
  Subject: Re: Feature request: smarter use of conditional indexes
  In-Reply-To: <200403081755.i28Htau25541@candle.pha.pa.us>
  References: <20141.1078631217@sss.pgh.pa.us> <200403081755.i28Htau25541@candle.pha.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox