From: Stephan Szabo <sszabo@megazone23.bigpanda.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kevin Brown <kevin@sysexperts.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PERFORM] Foreign key performance
Date: Sat, 19 Apr 2003 23:56:56 -0700 (PDT)
Message-ID: <20030419235530.S23637-100000@megazone23.bigpanda.com> (raw)
In-Reply-To: <23461.1050785882@sss.pgh.pa.us>
On Sat, 19 Apr 2003, Tom Lane wrote:
> Stephan Szabo <sszabo@megazone23.bigpanda.com> writes:
> > The hack was just the keeping around the list pointer from the last run
> > through (see attached - passed simple fk tests and regression, but there
> > might be problems I don't see).
>
> Shouldn't this patch update the comment in deferredTriggerInvokeEvents
> (c. line 1860 in cvs tip)?
Probably, since the second part of that is basically what this is. I'll
update and send updated patch tomorrow.
> > Looking at the code, I also wonder if we
> > would get some gain by not allocating the per_tuple_context at the
> > beginning but only when a non-deferred constraint is found since otherwise
> > we're creating and destroying the context and possibly never using it.
>
> I doubt it's worth worrying over. Creation/destruction of a never-used
> memory context is pretty cheap, I think.
Okay, sounds good enough for me. :)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-performance@postgresql.org
Cc: sszabo@megazone23.bigpanda.com, tgl@sss.pgh.pa.us, kevin@sysexperts.com, pgsql-hackers@postgresql.org
Subject: Re: [PERFORM] Foreign key performance
In-Reply-To: <20030419235530.S23637-100000@megazone23.bigpanda.com>
References: <23461.1050785882@sss.pgh.pa.us> <20030419235530.S23637-100000@megazone23.bigpanda.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox