pg.ddx.io  pgsql-performance@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Larry Rosenman <ler@lerctr.org>
Cc: John Siracusa <siracusa@mindspring.com>
Cc: Postgres Performance <pgsql-performance@postgresql.org>
Subject: Re: Feature request: smarter use of conditional indexes
Date: Sat, 06 Mar 2004 22:46:57 -0500
Message-ID: <20141.1078631217@sss.pgh.pa.us> (raw)
In-Reply-To: <32080000.1078627178@lerlaptop.lerctr.org>
References: <41C473B6-6FDF-11D8-9156-000A95BA4506@mindspring.com>
	<32080000.1078627178@lerlaptop.lerctr.org>

Larry Rosenman <ler@lerctr.org> writes:
> Just a suggestion, please use diff -c format, as it makes it easier for
> the folks who apply the patches to do so.

That's not just a suggestion ... patches that aren't in diff -c (or at
least diff -u) format will be rejected out of hand.  Without the context
lines provided by these formats, applying a patch is an exercise in
risk-taking, because you can't be certain that you are applying the same
patch the submitter intended.

Personally I consider -c format the only one of the three that is
readable for reviewing purposes, so even if I weren't intending
immediate application, I'd ask for -c before looking at the patch.
There are some folks who consider -u format readable, but I'm not
one of them ...

BTW, patches really ought to go to pgsql-patches ... they're a bit
off-topic here.

			regards, tom lane



view thread (11+ messages)  latest in thread

Message-ID: <20141.1078631217@sss.pgh.pa.us>
Permalink:  ../20141.1078631217@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/20141.1078631217@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-performance@postgresql.org
  Cc: tgl@sss.pgh.pa.us, ler@lerctr.org, siracusa@mindspring.com
  Subject: Re: Feature request: smarter use of conditional indexes
  In-Reply-To: <20141.1078631217@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox