pg.ddx.io  pgsql-performance@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Stephen Frost <sfrost@snowman.net>
To: Jim Nasby <Jim.Nasby@BlueTreble.com>
Cc: Vladimir Borodin <root@simply.name>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Dinesh Chandra 12108 <Dinesh.Chandra@cyient.com>
Cc: Madusudanan.B.N <b.n.madusudanan@gmail.com>
Cc: pgsql-performance@postgresql.org <pgsql-performance@postgresql.org>
Cc: David Steele <david@pgmasters.net>
Subject: Re: Backup taking long time !!!
Date: Mon, 23 Jan 2017 10:27:22 -0500
Message-ID: <20170123152722.GX18360@tamriel.snowman.net> (raw)
In-Reply-To: <68f87a97-15c2-5e4e-5730-77f9af2ca165@BlueTreble.com>
References: <23dc5b1ea9604ec3afdaabdd15491085@cyient.com>
	<CAFj8pRAHx-Wt4fyJmF=YH-F2_S=mO2E+=JDx+qnunkDP5_FPGA@mail.gmail.com>
	<b0748fe40949446283068a4d2d06c158@cyient.com>
	<CAFj8pRBFDh=hsghE8v5F71KztyczR7iWBXGJBOLLhUQDwUh8MQ@mail.gmail.com>
	<20170120122224.GF18360@tamriel.snowman.net>
	<DE553F58-646E-49E8-94D1-31794C3E9040@simply.name>
	<20170120134054.GH18360@tamriel.snowman.net>
	<7696A57C-C871-4A45-9141-FFD5F75CCB65@simply.name>
	<20170120150646.GP18360@tamriel.snowman.net>
	<68f87a97-15c2-5e4e-5730-77f9af2ca165@BlueTreble.com>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-performance>

* Jim Nasby (Jim.Nasby@BlueTreble.com) wrote:
> On 1/20/17 9:06 AM, Stephen Frost wrote:
> >All the pages are the same size, so I'm surprised you didn't consider
> >just having a format along the lines of: magic+offset+page,
> >magic+offset+page, magic+offset+page, etc...
> 
> Keep in mind that if you go that route you need to accommodate BLKSZ
> <> 8192.

If you want my 2c on that, running with BLKSZ <> 8192 is playing with
fire, or at least running with scissors.

That said, yes, the code should either barf when BLKSZ <> 8192 in a very
clear way early on, or handle it correctly, and be tested with such
configurations.

Thanks!

Stephen

Attachments:

  signature.asc (application/pgp-signature, 818B) download

view thread (42+ messages)  latest in thread

Message-ID: <20170123152722.GX18360@tamriel.snowman.net>
Permalink:  ../20170123152722.GX18360@tamriel.snowman.net/
Also on:    postgresql.org/message-id/20170123152722.GX18360@tamriel.snowman.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-performance@postgresql.org
  Cc: sfrost@snowman.net, Jim.Nasby@BlueTreble.com, root@simply.name, pavel.stehule@gmail.com, Dinesh.Chandra@cyient.com, b.n.madusudanan@gmail.com, david@pgmasters.net
  Subject: Re: Backup taking long time !!!
  In-Reply-To: <20170123152722.GX18360@tamriel.snowman.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox