From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jan Wieck <JanWieck@Yahoo.com>
Cc: Robert Treat <xzilla@users.sourceforge.net>
Cc: Christopher Kings-Lynne <chriskl@familyhealth.com.au>
Cc: Gourish Singbal <gourish@gmail.com>
Cc: Russell Smith <mr-russ@pws.com.au>
Cc: pgsql-performance@postgresql.org
Subject: Re: column name is "LIMIT"
Date: Mon, 14 Mar 2005 14:30:39 -0500
Message-ID: <29101.1110828639@sss.pgh.pa.us> (raw)
In-Reply-To: <4235DE36.2070608@Yahoo.com>
References: <674d1f8a0503132314754df153@mail.gmail.com>
<200503141825.22827.mr-russ@pws.com.au>
<674d1f8a05031400482c413087@mail.gmail.com>
<42355185.3070803@familyhealth.com.au>
<1110824915.4281.123.camel@camel>
<4235DE36.2070608@Yahoo.com>
Jan Wieck <JanWieck@Yahoo.com> writes:
> quote_ident() function doesn't quote reserved words ... as it IMHO is
> supposed to do.
You're right, it probably should. The equivalent code in pg_dump knows
about this, but quote_ident() doesn't.
One thing that's been on my mind with respect to all this is that it
would be nice not to quote "non-reserved" keywords. Most of the weird
non-SQL-spec keywords that we have are non-reserved, and we could more
easily keep them out of people's faces if we didn't quote them in dumps.
Of course such a policy would raise the ante for any change that makes
an existing keyword reserved when it wasn't before, but that's already
a dangerous kind of change.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: tgl@sss.pgh.pa.us, JanWieck@Yahoo.com, xzilla@users.sourceforge.net, chriskl@familyhealth.com.au, gourish@gmail.com, mr-russ@pws.com.au
Subject: Re: column name is "LIMIT"
In-Reply-To: <29101.1110828639@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox