pg.ddx.io  pgsql-performance@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Thomas Kellerer <spam_eater@gmx.net>
Cc: pgsql-performance@lists.postgresql.org
Subject: Re: Bloom index cost model seems to be wrong
Date: Tue, 12 Feb 2019 16:17:23 -0500
Message-ID: <3997.1550006243@sss.pgh.pa.us> (raw)
In-Reply-To: <CAMkU=1xyzYcjHdCdt8pcY4rvoh0xeP1kb8kvhWiF5fyTYFgBPA@mail.gmail.com>
References: <dc54f6e8-c6bf-6869-08c2-de855de470ae@gmx.net>
	<2126.1549986118@sss.pgh.pa.us>
	<CAMkU=1x9ML8PPmPKM0x7OVv6oUFn4b8s50suj2jcCOT78TLkzQ@mail.gmail.com>
	<CAMkU=1xyzYcjHdCdt8pcY4rvoh0xeP1kb8kvhWiF5fyTYFgBPA@mail.gmail.com>

Jeff Janes <jeff.janes@gmail.com> writes:
> In order for bloom (or any other users of CREATE ACCESS METHOD, if there
> are any) to have a fighting chance to do better, I think many of selfuncs.c
> currently private functions would have to be declared in some header file,
> perhaps utils/selfuncs.h.  But that then requires a cascade of other
> inclusions.  Perhaps that is why it was not done.

I'm just in the midst of refactoring that stuff, so if you have
suggestions, let's hear 'em.

It's possible that a good cost model for bloom is so far outside
genericcostestimate's ideas that trying to use it is not a good
idea anyway.

			regards, tom lane




view thread (12+ messages)  latest in thread

Message-ID: <3997.1550006243@sss.pgh.pa.us>
Permalink:  ../3997.1550006243@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3997.1550006243@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-performance@postgresql.org
  Cc: tgl@sss.pgh.pa.us, jeff.janes@gmail.com, spam_eater@gmx.net, pgsql-performance@lists.postgresql.org
  Subject: Re: Bloom index cost model seems to be wrong
  In-Reply-To: <3997.1550006243@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox