pg.ddx.io  pgsql-performance@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: John A Meinel <john@arbash-meinel.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Magnus Hagander <mha@sollentuna.net>
Cc: Ken Egervari <ken@upfactor.com>
Cc: pgsql-performance@postgresql.org
Cc: pgsql-hackers-win32@postgresql.org
Subject: Re: [PERFORM] Help with tuning this query (with
Date: Mon, 07 Mar 2005 11:24:07 -0600
Message-ID: <422C8E37.8000009@arbash-meinel.com> (raw)
In-Reply-To: <2555.1110213531@sss.pgh.pa.us>
References: <6BCB9D8A16AC4241919521715F4D8BCE476A60@algol.sollentuna.se>
	<23086.1110206737@sss.pgh.pa.us>
	<422C817A.8050009@arbash-meinel.com>
	<2555.1110213531@sss.pgh.pa.us>

Tom Lane wrote:

>John A Meinel <john@arbash-meinel.com> writes:
>
>
>>>>Can we just replace gettimeofday() with a version that's basically:
>>>>
>>>>
>>>No, because it's also used for actual time-of-day calls.  It'd be
>>>necessary to hack executor/instrument.c in particular.
>>>
>>>
>
>
>
>>Or we modify the win32 gettimeofday call to something like:
>>
>>
>
>That's what Magnus was talking about, but it's really no good because
>it would cause Postgres' now() function to fail to track post-boot-time
>changes in the system date setting.  Which I think would rightly be
>considered a bug.
>
>The EXPLAIN ANALYZE instrumentation code will really be happier with a
>straight time-since-bootup counter; by using gettimeofday, it is
>vulnerable to giving wrong answers if someone changes the date setting
>while the EXPLAIN is running.  But there is (AFAIK) no such call among
>the portable Unix syscalls.  It seems reasonable to me to #ifdef that
>code to make use of QueryPerformanceCounter on Windows.  This does not
>mean we want to alter the behavior of gettimeofday() where it's being
>used to find out the time of day.
>
>			regards, tom lane
>
>
>

What if you changed the "initialized" to

if (count & 0xFF == 0) {
  count = 1;
  // get the new time of day
}
++count;

Then we would only be wrong for 256 gettimeofday calls. I agree it isn't
great, though. And probably better to just abstract (possibly just with
#ifdef) the calls for accurate timing, from the calls that actually need
the real time.

John
=:->

Attachments:

  signature.asc (application/pgp-signature, 255B) download

view thread (16+ messages)  latest in thread

Message-ID: <422C8E37.8000009@arbash-meinel.com>
Permalink:  ../422C8E37.8000009@arbash-meinel.com/
Also on:    postgresql.org/message-id/422C8E37.8000009@arbash-meinel.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-performance@postgresql.org
  Cc: john@arbash-meinel.com, tgl@sss.pgh.pa.us, mha@sollentuna.net, ken@upfactor.com, pgsql-hackers-win32@postgresql.org
  Subject: Re: [PERFORM] Help with tuning this query (with
  In-Reply-To: <422C8E37.8000009@arbash-meinel.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox