pg.ddx.io  pgsql-performance@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Luke Lonergan <LLonergan@greenplum.com>
Cc: Alvaro Herrera <alvherre@surnet.cl>
Cc: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: Alon Goldshuv <agoldshuv@greenplum.com>
Cc: pgsql-patches@postgresql.org
Subject: Re: COPY FROM performance improvements
Date: Mon, 27 Jun 2005 07:45:19 -0400
Message-ID: <42BFE6CF.1030101@dunslane.net> (raw)
In-Reply-To: <3E37B936B592014B978C4415F90D662D0C420B@MI8NYCMAIL06.Mi8.com>
References: <3E37B936B592014B978C4415F90D662D0C420B@MI8NYCMAIL06.Mi8.com>



Luke Lonergan wrote:

>Yah - I think I fixed several mis-indented comments.  I'm using vim with
>tabstop=4.  I personally don't like tabs in text and would prefer them
>expanded using spaces, but that's a nice way to make small formatting
>changes look huge in a cvs diff.
>
>  
>

You might like to look at running pgindent (see src/tools/pgindent) over 
the file before cutting a patch. Since this is usually run over each 
file just before a release, the only badness should be things from 
recent patches.

cheers

andrew



view thread (52+ messages)  latest in thread

Message-ID: <42BFE6CF.1030101@dunslane.net>
Permalink:  ../42BFE6CF.1030101@dunslane.net/
Also on:    postgresql.org/message-id/42BFE6CF.1030101@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-performance@postgresql.org
  Cc: andrew@dunslane.net, LLonergan@greenplum.com, alvherre@surnet.cl, pgman@candle.pha.pa.us, agoldshuv@greenplum.com, pgsql-patches@postgresql.org
  Subject: Re: COPY FROM performance improvements
  In-Reply-To: <42BFE6CF.1030101@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox