From: Andrew Dunstan <andrew@dunslane.net>
To: Luke Lonergan <llonergan@greenplum.com>
Cc: Alvaro Herrera <alvherre@surnet.cl>
Cc: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: Alon Goldshuv <agoldshuv@greenplum.com>
Cc: pgsql-patches@postgresql.org
Subject: Re: COPY FROM performance improvements
Date: Mon, 27 Jun 2005 16:20:24 -0400
Message-ID: <42C05F88.7000105@dunslane.net> (raw)
In-Reply-To: <BEE59901.7E8E%llonergan@greenplum.com>
References: <BEE59901.7E8E%llonergan@greenplum.com>
Luke Lonergan wrote:
>Andrew,
>
>
>
>>You might like to look at running pgindent (see src/tools/pgindent) over
>>the file before cutting a patch. Since this is usually run over each
>>file just before a release, the only badness should be things from
>>recent patches.
>>
>>
>
>I've attached two patches, one gained from running pgindent against the
>current CVS tip copy.c (:-D) and one gained by running the COPY FROM perf
>improvements through the same. Nifty tool!
>
>Only formatting changes in these.
>
>
>
>
Luke,
Something strange has happened. I suspect that you've inadvertantly used
GNU indent or an unpatched BSD indent. pgindent needs a special patched
BSD indent to work according to the PG standards - see the README
cheers
andrew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: andrew@dunslane.net, llonergan@greenplum.com, alvherre@surnet.cl, pgman@candle.pha.pa.us, agoldshuv@greenplum.com, pgsql-patches@postgresql.org
Subject: Re: COPY FROM performance improvements
In-Reply-To: <42C05F88.7000105@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox