pg.ddx.io  pgsql-php@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: cmr@shell.gis.net
To: pgsql-php@postgresql.org
Subject: volunteer/peer review request
Date: Sat, 22 Mar 2003 17:09:44 -0500
Message-ID: <20030322220944.GB416@ssbeagle> (raw)

I trust and value the opinions of the members of this list.  Please give
me some constructive criticism on the following code:

http://webdevel.urban.csuohio.edu/lcua_pub/reveal_pub_retrieve.php

Sorry, no control over the colors, if you want plain vanilla:

http://webdevel.urban.csuohio.edu/lcua_pub/pub_retrieve.inc


I have placed comments and cleaned up to the line:

elseif (array_search('submit', $_GET) == "keyword")


Please let me know if this code:

	1) makes sense
	2) is readable
	3) is robust
	4) is flexible
	5) and anything else you want to tell me (well, anything helpful and
constructive).

I am a sole PHP/postgresql programmer in a college full of people who want to
do projects that would involve this as a model.

This is by no means a finished product, it is simply a beginning tool to
get us all started and acclimated here to internet interfaces to
database backends.

I'm comfortable with PHP, but am no professional.  My learning tool is
the documentation that came with both PostgreSQL and PHP, as well as a
few Zend tutorials.

Thank you,
-- 
-- 
Chadwick Rolfs




view thread (2+ messages)  latest in thread

Message-ID: <20030322220944.GB416@ssbeagle>
Permalink:  ../20030322220944.GB416@ssbeagle/
Also on:    postgresql.org/message-id/20030322220944.GB416@ssbeagle

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-php@postgresql.org
  Cc: cmr@shell.gis.net
  Subject: Re: volunteer/peer review request
  In-Reply-To: <20030322220944.GB416@ssbeagle>
  References: <20030322220944.GB416@ssbeagle>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox