From: Thom Brown <thombrown@gmail.com>
To: Csaba Nagy <nagy@ecircle-ag.com>
Cc: pgsql-php@postgresql.org <pgsql-php@postgresql.org>
Cc: pgsql-general@postgresql.org <pgsql-general@postgresql.org>
Subject: Re: PostgreSQL driver for Joomla review
Date: Wed, 21 Oct 2009 10:17:59 +0100
Message-ID: <bddc86150910210217v1a857de1ua119560aff37b208@mail.gmail.com> (raw)
In-Reply-To: <1256115162.3362.596.camel@pcd12478>
References: <bddc86150910200502j201b60d5l569b5da410aed402@mail.gmail.com>
<1256043135.3362.488.camel@pcd12478>
<bddc86150910200600l3fde5dfcobf854707c0509fba@mail.gmail.com>
<1256044824.28209.3.camel@raker.ateb.com>
<bddc86150910200628h1c63bcdfq42ce5f58c314497a@mail.gmail.com>
<1256115162.3362.596.camel@pcd12478>
2009/10/21 Csaba Nagy <nagy@ecircle-ag.com>:
> Hi Thom,
>
> Sorry for the delay, I got sick in the meantime. I see that others
> already did some review, I will do a quick one too, later maybe I'll
> actually try it out... so after a quick review:
>
> * on line 218, the " ENCODING '$DBname')" part feels wrong, you probably
> want hardcoded UTF8 encoding there ?
> * as Merlin already commented, transactions are always safe in postgres,
> this is no mysql ;-)
> * again, as Merlin commented, getTableList is getting the data bases,
> which doesn't make sense, but maybe you actually wanted to get the
> tables - in this case you don't have a typo but you need to change the
> query ;-)
>
> If I'll get some time I'll test it too, but likely not this week...
Thanks for the feedback Csaba,
Yes, I will change the function which uses transactions, and also
replace any conditional UTF8 statements with hard-coded ones.
The getTableList function...erm... not sure what I was thinking there.
How about:
select tablename from pg_tables where schemaname='public';
As for testing it, you won't be able to with the existing Joomla code
base as most of the queries will fail as they've been terribly
written, and that's because MySQL lets you get away with it for some
reason. I imagine the only way to test it is to either get a copy of
modified Joomla from me (although it still needs work), or create a
test app which uses that class, but you will need the parent JDatabase
class from Joomla too... and not sure how deep that rabbit hole goes
as that will also in turn inherit from another class.
Thanks again.
Thom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-php@postgresql.org
Cc: thombrown@gmail.com, nagy@ecircle-ag.com, pgsql-general@postgresql.org
Subject: Re: PostgreSQL driver for Joomla review
In-Reply-To: <bddc86150910210217v1a857de1ua119560aff37b208@mail.gmail.com>
References: <bddc86150910200502j201b60d5l569b5da410aed402@mail.gmail.com> <1256043135.3362.488.camel@pcd12478> <bddc86150910200600l3fde5dfcobf854707c0509fba@mail.gmail.com> <1256044824.28209.3.camel@raker.ateb.com> <bddc86150910200628h1c63bcdfq42ce5f58c314497a@mail.gmail.com> <1256115162.3362.596.camel@pcd12478> <bddc86150910210217v1a857de1ua119560aff37b208@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox