pg.ddx.io  pgsql-php@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Csaba Nagy <nagy@ecircle-ag.com>
To: Thom Brown <thombrown@gmail.com>
Cc: reid.thompson@ateb.com <reid.thompson@ateb.com>
Cc: pgsql-php@postgresql.org <pgsql-php@postgresql.org>
Cc: pgsql-general@postgresql.org <pgsql-general@postgresql.org>
Subject: Re: PostgreSQL driver for Joomla review
Date: Wed, 21 Oct 2009 10:52:42 +0200
Message-ID: <1256115162.3362.596.camel@pcd12478> (raw)
In-Reply-To: <bddc86150910200628h1c63bcdfq42ce5f58c314497a@mail.gmail.com>
References: <bddc86150910200502j201b60d5l569b5da410aed402@mail.gmail.com>
	<1256043135.3362.488.camel@pcd12478>
	<bddc86150910200600l3fde5dfcobf854707c0509fba@mail.gmail.com>
	<1256044824.28209.3.camel@raker.ateb.com>
	<bddc86150910200628h1c63bcdfq42ce5f58c314497a@mail.gmail.com>

Hi Thom,

Sorry for the delay, I got sick in the meantime. I see that others
already did some review, I will do a quick one too, later maybe I'll
actually try it out... so after a quick review:

* on line 218, the " ENCODING '$DBname')" part feels wrong, you probably
want hardcoded UTF8 encoding there ?
* as Merlin already commented, transactions are always safe in postgres,
this is no mysql ;-)
* again, as Merlin commented, getTableList is getting the data bases,
which doesn't make sense, but maybe you actually wanted to get the
tables - in this case you don't have a typo but you need to change the
query ;-)

If I'll get some time I'll test it too, but likely not this week...

Cheers,
Csaba.


On Tue, 2009-10-20 at 15:28 +0200, Thom Brown wrote:
> 2009/10/20 Reid Thompson <reid.thompson@ateb.com>:
> > your attachment contains this...
> >
> > <?xml version="1.0" encoding="iso-8859-1"?>
> > <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
> >         "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";
> > <html xmlns="http://www.w3.org/1999/xhtml"; xml:lang="en" lang="en">
> >  <head>
> >  <title>403 - Forbidden</title>
> >  </head>
> >  <body>
> >  <h1>403 - Forbidden</h1>
> >  </body>
> > </html>
> >
> 
> Erk.. that's weird.  I got that too even after being logged in.  I'm
> not sure how anyone can review it if no-one has access to it.
> 
> I've attached my working version which differs only slightly to
> conform with coding-styles required by Joomla.
> 
> Apologies
> 
> Thom




view thread (10+ messages)  latest in thread

Message-ID: <1256115162.3362.596.camel@pcd12478>
Permalink:  ../1256115162.3362.596.camel@pcd12478/
Also on:    postgresql.org/message-id/1256115162.3362.596.camel@pcd12478

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-php@postgresql.org
  Cc: nagy@ecircle-ag.com, thombrown@gmail.com, reid.thompson@ateb.com, pgsql-general@postgresql.org
  Subject: Re: PostgreSQL driver for Joomla review
  In-Reply-To: <1256115162.3362.596.camel@pcd12478>
  References: <bddc86150910200502j201b60d5l569b5da410aed402@mail.gmail.com> <1256043135.3362.488.camel@pcd12478> <bddc86150910200600l3fde5dfcobf854707c0509fba@mail.gmail.com> <1256044824.28209.3.camel@raker.ateb.com> <bddc86150910200628h1c63bcdfq42ce5f58c314497a@mail.gmail.com> <1256115162.3362.596.camel@pcd12478>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox