public inbox for [email protected]  

help / color / mirror / Atom feed

From: Pop, Sebastian <[email protected]>
To: Christoph Berg <[email protected]>
To: PostgreSQL in Debian <[email protected]>
To: Saidi, Ali <[email protected]>
To: Csoma, Csaba <[email protected]>
Subject: Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64
Date: Tue, 16 Nov 2021 14:31:50 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

> I will investigate the autoconf issue and send you a patch specific to PG10 and 9.
> Most likely the PGAC_PROG_CXX_CFLAGS_OPT macro has been introduced after these releases.

The above macro has been added in March 2018:
https://github.com/postgres/postgres/commit/6869b4f2584787d9e4cefaab8a4bae1ecbe63766
the patch also adds CXXFLAGS, and so before this patch there is no need to detect CXXFLAGS.

Please see attached a patch tested on Ubuntu 20.04 on the following branches:
remotes/origin/REL9_6_STABLE
remotes/origin/REL_10_STABLE

I checked that REL_11_STABLE has the CXXFLAGS and the above macro.

Thanks,
Sebastian


Attachments:

  [text/x-patch] outline-atomics-pg-9.6.diff (535B, 2-outline-atomics-pg-9.6.diff)
  download | inline diff:
diff --git a/configure.in b/configure.in
index 0ef9a3cca6..6dcedb68a3 100644
--- a/configure.in
+++ b/configure.in
@@ -475,6 +475,9 @@ if test "$GCC" = yes -a "$ICC" = no; then
   if test -n "$NOT_THE_CFLAGS"; then
     CFLAGS="$CFLAGS -Wno-stringop-truncation"
   fi
+  if test x"$host_cpu" == x"aarch64"; then
+    PGAC_PROG_CC_CFLAGS_OPT([-moutline-atomics])
+  fi
 elif test "$ICC" = yes; then
   # Intel's compiler has a bug/misoptimization in checking for
   # division by NAN (NaN == 0), -mp1 fixes it, so add it to the CFLAGS.

view thread (26+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox