pg.ddx.io  pgsql-pkg-debian@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Christoph Berg <myon@debian.org>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-pkg-debian@postgresql.org
Subject: Re: amcheck packages
Date: Sun, 1 Oct 2017 20:42:47 +0200
Message-ID: <20171001184247.6behs6v6po3caizw@msg.df7cb.de> (raw)
In-Reply-To: <CAH2-WzmxNKFmv3R4uEzUsvNzvNF_twB0QF4c-JSnCub0mnRNog@mail.gmail.com>
References: <CAH2-WzmxNKFmv3R4uEzUsvNzvNF_twB0QF4c-JSnCub0mnRNog@mail.gmail.com>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-pkg-debian>

Re: Peter Geoghegan 2017-10-01 <CAH2-WzmxNKFmv3R4uEzUsvNzvNF_twB0QF4c-JSnCub0mnRNog@mail.gmail.com>
> I would like to make amcheck available in the pgdg apt repo, in order
> to target earlier PostgreSQL versions. It's available as a contrib
> extension for v10 already, but there is no reason why it cannot be
> used on earlier versions. The Github version has the ability to build
> deb packages already:
> 
> https://github.com/petergeoghegan/amcheck
> 
> I'll also want to make available the enhancement that is proposed for
> Postgres 11, from the current commitfest [1]. So, the goal will be to
> target Postgres 9.4, 9.5, 9.6, and 10 - v10 will not have an enhanced
> version, which I believe adds significantly more value.
> 
> Is there an acceptance process? How can I get the ball rolling on that?

Hi Peter,

all we need is a proper debian/ directory, which your repository
already has. The packaging looks good, even including tests, cool :)

I've configured the build jobs in our jenkins and gave it a go. The
build almost worked, the only problem is that the topmost changelog
entry in debian/changelog has a malformed timestamp which dpkg is
complaining about. On Ubuntu zesty, that problem is even fatal. For
the other dists, everything worked including the testsuite.

Could you fix that changelog entry, possibly adding a 0.3-2 or 0.4-1
stanza? If you use "dch" (dch -i) to edit the changelog, it will take
care of the timestamp.

Also, if you want to build Debian packages from git repo's HEAD, it is
often easier to set debian/source/format to "1.0" which will disable
the "there are changes neither in the tarball nor in debian/patches"
check.

Christoph


-- 
Sent via pgsql-pkg-debian mailing list (pgsql-pkg-debian@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-debian



view thread (28+ messages)  latest in thread

Message-ID: <20171001184247.6behs6v6po3caizw@msg.df7cb.de>
Permalink:  ../20171001184247.6behs6v6po3caizw@msg.df7cb.de/
Also on:    postgresql.org/message-id/20171001184247.6behs6v6po3caizw@msg.df7cb.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-pkg-debian@postgresql.org
  Cc: myon@debian.org, pg@bowt.ie
  Subject: Re: amcheck packages
  In-Reply-To: <20171001184247.6behs6v6po3caizw@msg.df7cb.de>
  References: <CAH2-WzmxNKFmv3R4uEzUsvNzvNF_twB0QF4c-JSnCub0mnRNog@mail.gmail.com> <20171001184247.6behs6v6po3caizw@msg.df7cb.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox