pg.ddx.io  pgsql-pkg-debian@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Andreas Karlsson <andreas@proxel.se>
Cc: Fred .Flintstone <eldmannen@gmail.com>
Cc: Mark Kirkwood <mark.kirkwood@catalyst.net.nz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Chris Travers <chris.travers@adjust.com>
Cc: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Euler Taveira <euler@timbira.com.br>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: PostgreSQL pollutes the file system
Date: Wed, 27 Mar 2019 15:26:57 +0100
Message-ID: <20190327142657.GC17983@development> (raw)
In-Reply-To: <044a865f-c0c2-70e4-f4d0-ec841d701fda@proxel.se>
References: <20190321004919.GE20192@paquier.xyz>
	<CAN-RpxBfajcAmdP_ghBjXgGYq1f+vf_Em+P6LBqfCq=av2cumg@mail.gmail.com>
	<fdbcadf7-9edd-b20d-9987-4e7d21d23b2d@proxel.se>
	<10036.1553176960@sss.pgh.pa.us>
	<20190322003611.GK20192@paquier.xyz>
	<31754.1553220346@sss.pgh.pa.us>
	<3edd2644-eaf2-41e0-aa7a-92786d25b29c@catalyst.net.nz>
	<CAJgfmqXYYKXR+QUhEa3cq6pc8dV0Hu7QvOUccm7R0TkC=T-+=A@mail.gmail.com>
	<20190327135116.GA17983@development>
	<044a865f-c0c2-70e4-f4d0-ec841d701fda@proxel.se>

On Wed, Mar 27, 2019 at 03:07:24PM +0100, Andreas Karlsson wrote:
>On 3/27/19 2:51 PM, Tomas Vondra wrote:
>>I think the consensus in this thread (and the previous ancient ones) is
>>that it's not worth it. It's one thing to introduce new commands with the
>>pg_ prefix, and it's a completely different thing to rename existing ones.
>>That has inherent costs, and as Tom pointed out the burden would fall on
>>people using PostgreSQL (and that's rather undesirable).
>>
>>I personally don't see why having commands without pg_ prefix would be
>>an issue. Especially when placed in a separate directory, which eliminates
>>the possibility of conflict with other commands.
>
>I buy that it may not be worth breaking tens of thousands of scripts 
>to fix this, but I disagree about it not being an issue. Most Linux 
>distributions add PostgreSQL's executables in to a directory which is 
>in the default $PATH (/usr/bin in the case of Debian). And even if it 
>would be installed into a separate directory there would still be a 
>conflict as soon as that directory is added to $PATH.
>

That is true, of course. But are there actual examples of such conflicts
in practice? I mean, are there tools/packages that provide commands with
a conflicting name? I'm not aware of any, and as was pointed before, we'd
have ~20 years of history on any new ones.

>And I think that it is also relatively easy to confuse adduser and 
>createuser when reading a script. Nothing about the name createuser 
>indicates that it will create a role in an SQL database.
>

Sure, and I've confused those tools too in the past. But that's not
something you'll hit in a script, at least not if you test it before
running it on production system. And if you're running untested scripts,
this is likely the least of your problems ...

cheers

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services






view thread (113+ messages)  latest in thread

Message-ID: <20190327142657.GC17983@development>
Permalink:  ../20190327142657.GC17983@development/
Also on:    postgresql.org/message-id/20190327142657.GC17983@development

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-pkg-debian@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com, andreas@proxel.se, eldmannen@gmail.com, mark.kirkwood@catalyst.net.nz, tgl@sss.pgh.pa.us, michael@paquier.xyz, chris.travers@adjust.com, ishii@sraoss.co.jp, alvherre@2ndquadrant.com, euler@timbira.com.br, rjuju123@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: PostgreSQL pollutes the file system
  In-Reply-To: <20190327142657.GC17983@development>
  References: <20190321004919.GE20192@paquier.xyz> <CAN-RpxBfajcAmdP_ghBjXgGYq1f+vf_Em+P6LBqfCq=av2cumg@mail.gmail.com> <fdbcadf7-9edd-b20d-9987-4e7d21d23b2d@proxel.se> <10036.1553176960@sss.pgh.pa.us> <20190322003611.GK20192@paquier.xyz> <31754.1553220346@sss.pgh.pa.us> <3edd2644-eaf2-41e0-aa7a-92786d25b29c@catalyst.net.nz> <CAJgfmqXYYKXR+QUhEa3cq6pc8dV0Hu7QvOUccm7R0TkC=T-+=A@mail.gmail.com> <20190327135116.GA17983@development> <044a865f-c0c2-70e4-f4d0-ec841d701fda@proxel.se> <20190327142657.GC17983@development>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox