From: Christoph Berg <myon@debian.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: andreas@proxel.se
Cc: tomas.vondra@2ndquadrant.com
Cc: eldmannen@gmail.com
Cc: mark.kirkwood@catalyst.net.nz
Cc: michael@paquier.xyz
Cc: chris.travers@adjust.com
Cc: alvherre@2ndquadrant.com
Cc: euler@timbira.com.br
Cc: rjuju123@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: PostgreSQL pollutes the file system
Date: Fri, 29 Mar 2019 19:50:31 +0100
Message-ID: <20190329185031.GA19154@msg.df7cb.de> (raw)
In-Reply-To: <19517.1553876700@sss.pgh.pa.us>
References: <20190327142657.GC17983@development>
<375ea28a-2e8c-9954-66b1-bd0a3ff657f5@proxel.se>
<18182.1553697687@sss.pgh.pa.us>
<20190329.100407.1159785913847835944.t-ishii@sraoss.co.jp>
<20190329152557.GI20294@msg.df7cb.de>
<24256.1553874086@sss.pgh.pa.us>
<20190329155121.5zyoahgh4i2r4ayl@alap3.anarazel.de>
<19517.1553876700@sss.pgh.pa.us>
Re: Tom Lane 2019-03-29 <19517.1553876700@sss.pgh.pa.us>
> >> Or perhaps better, allow pg_ctl to grow new subcommands for those
> >> tasks?
>
> > We'd need to be careful to somehow delineate commands that need access
> > to the data directory / run locally on the server from the ones that
> > just needs a client connection.
>
> Hmm, that's a good point: to put it in terms that make sense to a
> packager, it'd no longer be clear whether pg_ctl belongs in the
> server package or the client package.
True, and putting end-user commands like "create database" into the
same admin tool like "stop", "promote", and "kill" feels both wrong
and dangerous to me. It would also cause people to wonder why "pg_ctl
-h remotehost stop" doesn't work.
> I'm still not thrilled with wedging in these things as options
> to psql though: its command line semantics are overly complicated
> already, when you consider things like multiple -c and -f options.
> I mean, somebody might think it's a feature to be able to do
>
> psql --createuser alice --createuser bob -c 'some command' -f somefile
>
> but I don't.
Ack. (Otoh, just processing all arguments after another might be
well-defined, and not too hard?)
> Maybe if we want to merge these things into one executable,
> it should be a new one. "pg_util createrole bob" ?
"pg" is unfortunately already taken :(
Fwiw, let's please keep supporting "createuser". Creating login roles
is more common than non-login ones, and having to type "createrole
--login bob" is cumbersome and will cause endless support requests by
confused users.
Other idea: If we don't want to reinvent a new tool, how about
supporting prepared statements in psql?
psql -c 'create user %i' --args 'bob w. space'
Christoph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-pkg-debian@postgresql.org
Cc: myon@debian.org, tgl@sss.pgh.pa.us, andres@anarazel.de, ishii@sraoss.co.jp, andreas@proxel.se, tomas.vondra@2ndquadrant.com, eldmannen@gmail.com, mark.kirkwood@catalyst.net.nz, michael@paquier.xyz, chris.travers@adjust.com, alvherre@2ndquadrant.com, euler@timbira.com.br, rjuju123@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: PostgreSQL pollutes the file system
In-Reply-To: <20190329185031.GA19154@msg.df7cb.de>
References: <20190327142657.GC17983@development> <375ea28a-2e8c-9954-66b1-bd0a3ff657f5@proxel.se> <18182.1553697687@sss.pgh.pa.us> <20190329.100407.1159785913847835944.t-ishii@sraoss.co.jp> <20190329152557.GI20294@msg.df7cb.de> <24256.1553874086@sss.pgh.pa.us> <20190329155121.5zyoahgh4i2r4ayl@alap3.anarazel.de> <19517.1553876700@sss.pgh.pa.us> <20190329185031.GA19154@msg.df7cb.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox