From: Tom Lane <tgl@sss.pgh.pa.us>
To: Christoph Berg <myon@debian.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: Jason Petersen <jason@citusdata.com>
Cc: pgsql-pkg-debian@postgresql.org, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] relocation truncated to fit: citus build failure on s390x
Date: Mon, 29 May 2017 15:45:11 -0400
Message-ID: <27883.1496087111@sss.pgh.pa.us> (raw)
In-Reply-To: <20170529155850.qojdfrwkkqnjb3ap@msg.df7cb.de>
References: <A37C3A5E-DDEA-40C9-BB67-133B42E4E0A8@citusdata.com>
<980D4281-A01F-4F5D-9874-FFED701F403F@citusdata.com>
<20160426151339.GF12563@msg.df7cb.de>
<20160426153235.GA2862@msg.df7cb.de>
<20160427230516.44fuzdxlifch2wwp@alap3.anarazel.de>
<20160428080824.GA22412@msg.df7cb.de>
<20170529155850.qojdfrwkkqnjb3ap@msg.df7cb.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Christoph Berg <myon@debian.org> writes:
> Re: To Andres Freund 2016-04-28 <20160428080824.GA22412@msg.df7cb.de>
>>> I'm not clear why citus triggers this, when other extensions don't?
>> Maybe it's simply because citus.so is bigger than all the other
>> extension .so files:
I wonder what the overhead is of using -fPIC when -fpic would be
sufficient. Whatever it is, the proposed patch imposes it on every
shlib or extension, to accommodate one single extension that isn't
even one we ship.
Maybe this is small enough to not be something we need to worry about,
but I'm wondering if we should ask citus and other large .so's to set
some additional make flag that would cue usage of -fPIC over -fpic.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-pkg-debian@postgresql.org
Cc: tgl@sss.pgh.pa.us, myon@debian.org, andres@anarazel.de, jason@citusdata.com, pgsql-hackers@postgresql.org
Subject: Re: [PATCH] relocation truncated to fit: citus build failure on s390x
In-Reply-To: <27883.1496087111@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox