public inbox for [email protected]
help / color / mirror / Atom feedFrom: Brian Cosgrove <[email protected]>
To: Christoph Berg <[email protected]>
To: Bradford Boyle <[email protected]>
To: [email protected]
Subject: Re: PgBouncer 1.24.0 - New upstream version
Date: Wed, 5 Feb 2025 06:40:41 -0600
Message-ID: <CAGKCzNCKAEEJmd5Fn5Be4zu1YxS9okBoeqBX15_RijvBgouqzA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAGKCzNBZO-AQMfmbfbn20wvE+63j50YuPBKJupYLiDCmc84OeA@mail.gmail.com>
<CAOMoQbROhu7WG9LnyjHb1RXJrax_HKKMBbwaou+jps0uZgqHFw@mail.gmail.com>
<CAOMoQbQzutP0UMU3KUZAE4A9Jf8bS=uSBRdUX7g=9xxoBbosmQ@mail.gmail.com>
<CAGKCzNAQKMKJ_BQcF=uzcfcM=vx8QYnT+jtzuv_yp=76zbhn7g@mail.gmail.com>
<CAGKCzNAW4BFq_cSKpnPvG6hRF65G3HptjUvWVW=DefPaPMF2pg@mail.gmail.com>
<CAGKCzNAJzhzxJ809y9e6ttYbL0k6id5KmkzmBrz5xZROd79etQ@mail.gmail.com>
<CAGKCzNC6RkY54TrkqqQ9K83AF=vrYe+CB14-PUSLTF5YMbzrmA@mail.gmail.com>
<CAOMoQbT3zRuL+YLeiUrOG5-vYsvrZ2MJF_DQoa3E94cBfdv6xw@mail.gmail.com>
<[email protected]>
<CAOMoQbTA2qOo+f_4JE+oYGupZANh-0msn_Pw36qb7v3PfT1e0w@mail.gmail.com>
<[email protected]>
Skipping this release for bullseye is not entirely unreasonable with Trixie
pending.
Skipping the entire suite feels unreasonable if the Postgres Debian team
releases 1.24.
I am working up a patch that will skip only these tests that will likely be
accepted upstream as well, should Debian choose to release 1.24 for
bullseye.
https://github.com/pgbouncer/pgbouncer/pull/1266
On Wed, Feb 5, 2025 at 3:10 AM Christoph Berg <[email protected]> wrote:
> Re: Bradford Boyle
> > I think we could go without tests on bullseye since it seems like we are
> > nearing the trixie release and bullseye will become old old stable.
> > (Correct me if I am wrong on this point, I'm making this assumption
> > based on the trixie freeze dates). There's probably little value in
> > creating extra work here.
>
> Or we just don't update the package on bullseye, leaving it at 1.23.1.
> But there is still the autopkgtest, so we still have test coverage
> there.
>
> > It looks like d/rules for pgbouncer will skip the tests if nocheck is in
> > DEB_BUILD_OPTIONS -- is this something that can be configured via the
> Jenkins
> > YAML? I am not very familiar with the Jenkins job builder YAML and I
> didn't see
> > any usages of that in the current set of jobs. Or would I need to update
> > generate-pgdg-source to include an additional tweak to disable the tests
> on
> > older platforms?
>
> Any of these would work.
>
> DEB_BUILD_OPTIONS=nocheck would have to be set in the sbuild-package
> script. That's probably the easiest way forward.
>
> The extra test dependencies need annotating with <!nocheck> so the
> build doesn't try to install them.
>
> Christoph
>
>
>
--
Brian Cosgrove
view thread (15+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: PgBouncer 1.24.0 - New upstream version
In-Reply-To: <CAGKCzNCKAEEJmd5Fn5Be4zu1YxS9okBoeqBX15_RijvBgouqzA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox