public inbox for [email protected]
help / color / mirror / Atom feedpgBackRest 2.52 - New upstream version
8+ messages / 3 participants
[nested] [flat]
* pgBackRest 2.52 - New upstream version
@ 2024-05-27 05:03 Bradford Boyle <[email protected]>
2024-06-03 19:52 ` Re: pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: Bradford Boyle @ 2024-05-27 05:03 UTC (permalink / raw)
To: [email protected]; +Cc: [email protected]
Hi All,
I've pushed a commit [1] updating the package version pgbackrest to 2.52
to salsa.debian.org. The GitLab CI is green and the package is ready for
review and upload.
--Bradford
[1]: https://salsa.debian.org/postgresql/pgbackrest/-/commit/4bed3fd233fae4bd09487d559b9251786b3260c4
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgBackRest 2.52 - New upstream version
2024-05-27 05:03 pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
@ 2024-06-03 19:52 ` Bradford Boyle <[email protected]>
2024-06-03 20:38 ` Re: pgBackRest 2.52 - New upstream version Christoph Berg <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: Bradford Boyle @ 2024-06-03 19:52 UTC (permalink / raw)
To: [email protected]; +Cc: [email protected]
Hi All,
Just following up to see if there are any blockers to having pgbackrest
uploaded.
--Bradford
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgBackRest 2.52 - New upstream version
2024-05-27 05:03 pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-03 19:52 ` Re: pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
@ 2024-06-03 20:38 ` Christoph Berg <[email protected]>
2024-06-03 20:41 ` Re: pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: Christoph Berg @ 2024-06-03 20:38 UTC (permalink / raw)
To: Bradford Boyle <[email protected]>; +Cc: [email protected]; [email protected]
Re: Bradford Boyle
> Just following up to see if there are any blockers to having pgbackrest
> uploaded.
Hi Bradford,
mostly me hiking in the woods for the last days...
But unfortunately, bullseye and focal are not happy:
../meson.build:117:0: ERROR: <ExternalProgram 'python3' -> ['/usr/bin/python3']> is not a valid python or it is missing setuptools
(Interestingly, buster is happy with the meson+python3 combination)
Christoph
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgBackRest 2.52 - New upstream version
2024-05-27 05:03 pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-03 19:52 ` Re: pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-03 20:38 ` Re: pgBackRest 2.52 - New upstream version Christoph Berg <[email protected]>
@ 2024-06-03 20:41 ` Bradford Boyle <[email protected]>
2024-06-03 22:33 ` Re: pgBackRest 2.52 - New upstream version David Steele <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: Bradford Boyle @ 2024-06-03 20:41 UTC (permalink / raw)
To: Christoph Berg <[email protected]>; +Cc: [email protected]; [email protected]
Hi Christoph,
> But unfortunately, bullseye and focal are not happy:
>
> ../meson.build:117:0: ERROR: <ExternalProgram 'python3' -> ['/usr/bin/python3']> is not a valid python or it is missing setuptools
>
> (Interestingly, buster is happy with the meson+python3 combination)
I will take a look at this later today and see if I can identify and
push a fix.
Thanks,
--Bradford
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgBackRest 2.52 - New upstream version
2024-05-27 05:03 pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-03 19:52 ` Re: pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-03 20:38 ` Re: pgBackRest 2.52 - New upstream version Christoph Berg <[email protected]>
2024-06-03 20:41 ` Re: pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
@ 2024-06-03 22:33 ` David Steele <[email protected]>
2024-06-04 03:36 ` Re: pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: David Steele @ 2024-06-03 22:33 UTC (permalink / raw)
To: Bradford Boyle <[email protected]>; Christoph Berg <[email protected]>; +Cc: [email protected]
On 6/4/24 06:41, Bradford Boyle wrote:
> Hi Christoph,
>
>> But unfortunately, bullseye and focal are not happy:
>>
>> ../meson.build:117:0: ERROR: <ExternalProgram 'python3' -> ['/usr/bin/python3']> is not a valid python or it is missing setuptools
>>
>> (Interestingly, buster is happy with the meson+python3 combination)
>
> I will take a look at this later today and see if I can identify and
> push a fix.
This is actually a bug/typo in older versions of meson. What is actually
required (in some cases) is python3-distutils. See
https://github.com/pgbackrest/pgbackrest/commit/e00e33b52. The purpose
of this commit is to not hardcode the python bin.
However, this requirement is only for certain older (but not too old)
versions of Debian/Ubuntu. Ubuntu 24.04, for instance, does not have
this package and works fine without it. Of the Ubuntu versions only
focal seems to require it. The only Debian version we currently have in
CI, stretch, does not require it.
It's a bit of a mess, but looks like we need to install
python3-distutils just for bullseye and focal as a build dependency. Is
that possible?
Regards,
-David
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgBackRest 2.52 - New upstream version
2024-05-27 05:03 pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-03 19:52 ` Re: pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-03 20:38 ` Re: pgBackRest 2.52 - New upstream version Christoph Berg <[email protected]>
2024-06-03 20:41 ` Re: pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-03 22:33 ` Re: pgBackRest 2.52 - New upstream version David Steele <[email protected]>
@ 2024-06-04 03:36 ` Bradford Boyle <[email protected]>
2024-06-04 09:43 ` Re: pgBackRest 2.52 - New upstream version Christoph Berg <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: Bradford Boyle @ 2024-06-04 03:36 UTC (permalink / raw)
To: David Steele <[email protected]>; +Cc: Christoph Berg <[email protected]>; [email protected]
Hi David and Christoph,
> This is actually a bug/typo in older versions of meson. What is actually
> required (in some cases) is python3-distutils.
I found [this issue][1] on GitHub repo for meson which indicates that
meson 0.48.0 added a dependency on python's setuptools module. This
issue is quite old but it was referenced by a [newer pull request][2]
that seems to indicate that at some point meson depended on python's
distutils module. This PR was referenced by an even [newer PR][3] that
seems to indicate that meson moved away from using the distutils module.
This is probably why this is only an issue in bullseye or focal and not
older or newer dists.
> It's a bit of a mess, but looks like we need to install
> python3-distutils just for bullseye and focal as a build dependency. Is
> that possible?
Adding python3-distutils for just bullseye and focal should be doable. I
believe the scripts used to build the packages for the PGDG apt repo has
an existing pattern for tweaking the package. Attached is a patch that
should add python3-distutils to pgbackrest's list of build dependencies
only on bullseye or focal.
--Bradford
[1]: https://github.com/mesonbuild/meson/issues/4267
[2]: https://github.com/mesonbuild/meson/pull/9288
[3]: https://github.com/mesonbuild/meson/pull/11133
Attachments:
[application/octet-stream] 0001-pgbackrest-Add-python3-distutils-dependency.patch (873B, 2-0001-pgbackrest-Add-python3-distutils-dependency.patch)
download | inline diff:
From 76f9b37c9eec2cd0e778e566363dea5f6c2e8784 Mon Sep 17 00:00:00 2001
From: "Bradford D. Boyle" <[email protected]>
Date: Mon, 3 Jun 2024 20:31:12 -0700
Subject: [PATCH] pgbackrest: Add python3-distutils dependency
---
jenkins/generate-pgdg-source | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/jenkins/generate-pgdg-source b/jenkins/generate-pgdg-source
index 151b1cd..6b5791a 100755
--- a/jenkins/generate-pgdg-source
+++ b/jenkins/generate-pgdg-source
@@ -290,6 +290,15 @@ case $PACKAGE in
esac
;;
+ pgbackrest)
+ case $distribution in
+ bullseye|focal)
+ sed -i -E 's/( +)(pkgconf,)/\1\2\n\1python3-distutils,/' debian/control
+ TWEAK+=("Add python3-distutils dependency")
+ ;;
+ esac
+ ;;
+
postgis)
case ${distribution:-} in
buster|stretch|focal|eoan|bionic|xenial)
--
2.45.2
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgBackRest 2.52 - New upstream version
2024-05-27 05:03 pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-03 19:52 ` Re: pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-03 20:38 ` Re: pgBackRest 2.52 - New upstream version Christoph Berg <[email protected]>
2024-06-03 20:41 ` Re: pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-03 22:33 ` Re: pgBackRest 2.52 - New upstream version David Steele <[email protected]>
2024-06-04 03:36 ` Re: pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
@ 2024-06-04 09:43 ` Christoph Berg <[email protected]>
2024-06-05 00:55 ` Re: pgBackRest 2.52 - New upstream version David Steele <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: Christoph Berg @ 2024-06-04 09:43 UTC (permalink / raw)
To: Bradford Boyle <[email protected]>; +Cc: David Steele <[email protected]>; [email protected]
Re: Bradford Boyle
> > It's a bit of a mess, but looks like we need to install
> > python3-distutils just for bullseye and focal as a build dependency. Is
> > that possible?
We should keep it simple and add it unconditionally. python3-distutils
is needed on python < 3.10, so I used this:
python3 (>= 3.10) | python3-distutils
Christoph
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgBackRest 2.52 - New upstream version
2024-05-27 05:03 pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-03 19:52 ` Re: pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-03 20:38 ` Re: pgBackRest 2.52 - New upstream version Christoph Berg <[email protected]>
2024-06-03 20:41 ` Re: pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-03 22:33 ` Re: pgBackRest 2.52 - New upstream version David Steele <[email protected]>
2024-06-04 03:36 ` Re: pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-04 09:43 ` Re: pgBackRest 2.52 - New upstream version Christoph Berg <[email protected]>
@ 2024-06-05 00:55 ` David Steele <[email protected]>
0 siblings, 0 replies; 8+ messages in thread
From: David Steele @ 2024-06-05 00:55 UTC (permalink / raw)
To: Christoph Berg <[email protected]>; Bradford Boyle <[email protected]>; +Cc: [email protected]
On 6/4/24 19:43, Christoph Berg wrote:
> Re: Bradford Boyle
>>> It's a bit of a mess, but looks like we need to install
>>> python3-distutils just for bullseye and focal as a build dependency. Is
>>> that possible?
>
> We should keep it simple and add it unconditionally. python3-distutils
> is needed on python < 3.10, so I used this:
>
> python3 (>= 3.10) | python3-distutils
>
This seems reasonable, though I do wish there was a meson-specific way
to fix this. I guess their answer would be to upgrade.
Regards,
-David
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2024-06-05 00:55 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-05-27 05:03 pgBackRest 2.52 - New upstream version Bradford Boyle <[email protected]>
2024-06-03 19:52 ` Bradford Boyle <[email protected]>
2024-06-03 20:38 ` Christoph Berg <[email protected]>
2024-06-03 20:41 ` Bradford Boyle <[email protected]>
2024-06-03 22:33 ` David Steele <[email protected]>
2024-06-04 03:36 ` Bradford Boyle <[email protected]>
2024-06-04 09:43 ` Christoph Berg <[email protected]>
2024-06-05 00:55 ` David Steele <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox