public inbox for [email protected]
help / color / mirror / Atom feedFrom: Esteban Zimanyi <[email protected]>
To: Cédric Villemain <[email protected]>
Cc: Bradford Boyle <[email protected]>
Cc: [email protected]
Cc: SCHOEMANS Maxime <[email protected]>
Subject: Re: Packaging request MobilityDB
Date: Wed, 7 Jun 2023 18:25:57 +0200
Message-ID: <CAPqRbE4QXeno00wdRU6dy8h9AFr8z1o1keSpxN6=T8eW8jCM_A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAPqRbE716D3gpD0JDbaFAb72ELaJrPpG1LUZvobELNBgL3R0+g@mail.gmail.com>
<CAOMoQbRMo5HM4eMsUmcQ+5_eGUZK6zycMgifnEehbooee+L5HA@mail.gmail.com>
<CAOMoQbQPOs827ZNk2atm0JHQYDJ4iW339a8HxovxUZzpa4RjtA@mail.gmail.com>
<CAPqRbE7W2ifWkjAGZ36cAE1kd23m0gmz5sgn_49MWam2kA+=CQ@mail.gmail.com>
<[email protected]>
We regenerated all the tests using timezone = 'PST8PDT' and datestyle =
'Postgres, MDY'
https://github.com/estebanzimanyi/MobilityDB/blob/pst/mobilitydb/test/scripts/test.cmake#L100
https://github.com/estebanzimanyi/MobilityDB/commit/d67b817b079ea7340774c88a0a6aaf577a2f3292
and all the test passed for ubuntu but not for macOS
https://github.com/estebanzimanyi/MobilityDB/actions/runs/5202100740/jobs/9383217151
https://github.com/estebanzimanyi/MobilityDB/actions/runs/5202100734/jobs/9383216304
Any idea how to solve this ?
Thanks for your help
Esteban
On Wed, Jun 7, 2023 at 5:51 PM Cédric Villemain <[email protected]>
wrote:
> Le 07/06/2023 à 17:16, Esteban Zimanyi a écrit :
>
> Dear Bradford
>
> Many thanks for your work.
>
>
> Seconded! and tks for MobilityDB too !
>
>
> * We solved the stack smashing problem you found.
> * We set the log_error_verbosity to terse for the tests and removed the
> special treatment of ERROR, CONTEXT, and WARNING that may vary across
> PostgreSQL and PostGIS versions.
> * For the tests, we can easily switch to the settings 'PST8PDT' for the
> timezone and 'Postgres, MDY' for the date style if this is the general way
> to do things. We simply need to regenerate all tests and push them in a new
> commit. We just wonder if the same settings are equally valid for all other
> distributions. Please advise.
>
> Yeah, 'PST8PDT' is the way to go for PostgreSQL test [1]
>
> I believe it's valid for other distributions.
>
> Apparently datestyle is not documented here, but pg_regress does:
>
> /*
> * Set timezone and datestyle for datetime-related tests
> */
> setenv("PGTZ", "PST8PDT", 1);
> setenv("PGDATESTYLE", "Postgres, MDY", 1);
>
> see also [2] which might be useful as it mentions some corner cases for
> other systems.
>
>
>
> [1]:
> https://www.postgresql.org/docs/current/regress-evaluation.html#id-1.6.20.6.8
>
> [2]: https://doxygen.postgresql.org/pg__regress_8c_source.html#l00702
>
> ---
> Cédric Villemain +33 (0)6 20 30 22 52https://Data-Bene.io
> PostgreSQL: Expertise - Formation - Développement - Assistance Technique
>
>
view thread (18+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Packaging request MobilityDB
In-Reply-To: <CAPqRbE4QXeno00wdRU6dy8h9AFr8z1o1keSpxN6=T8eW8jCM_A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox