public inbox for [email protected]  
help / color / mirror / Atom feed
A basic spec file question
3+ messages / 3 participants
[nested] [flat]

* A basic spec file question
@ 2020-10-02 09:08  Devrim Gündüz <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Devrim Gündüz @ 2020-10-02 09:08 UTC (permalink / raw)
  To: PostgreSQL YUM ML <[email protected]>



Hi,

I am probably missing a very basic thing, but... What is wrong in this
line? I am expecting Fedora 32 and 33 not do depend on CGAL package,
but then the Fedora 33 RPM depends on CGAL >= 4.7 .

https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/master/common/sfcgal/master/sfcg...

What am I missing?

Regards,
-- 
Devrim Gündüz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR


Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: A basic spec file question
@ 2020-10-02 09:37  Craig Ringer <[email protected]>
  parent: Devrim Gündüz <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Craig Ringer @ 2020-10-02 09:37 UTC (permalink / raw)
  To: Devrim Gündüz <[email protected]>; +Cc: PostgreSQL YUM ML <[email protected]>

Add a %dump at the end of the spec file body and/or relevant parts
throughout to see how it evaluated. %echo macros are useful too

On Fri, 2 Oct 2020, 17:08 Devrim Gündüz, <[email protected]> wrote:

>
>
> Hi,
>
> I am probably missing a very basic thing, but... What is wrong in this
> line? I am expecting Fedora 32 and 33 not do depend on CGAL package,
> but then the Fedora 33 RPM depends on CGAL >= 4.7 .
>
>
> https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/master/common/sfcgal/master/sfcg...
>
> What am I missing?
>
> Regards,
> --
> Devrim Gündüz
> Open Source Solution Architect, Red Hat Certified Engineer
> Twitter: @DevrimGunduz , @DevrimGunduzTR
>


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: A basic spec file question
@ 2020-10-02 11:04  Heath Lord <[email protected]>
  parent: Craig Ringer <[email protected]>
  0 siblings, 0 replies; 3+ messages in thread

From: Heath Lord @ 2020-10-02 11:04 UTC (permalink / raw)
  To: Craig Ringer <[email protected]>; +Cc: Devrim Gündüz <[email protected]>; PostgreSQL YUM ML <[email protected]>

Devrim,

   The issue is with the "<=" in this line:

%if 0%{?fedora} <= 31 || 0%{?rhel} <= 8 || 0%{?suse_version} >= 1315

   With the "0%{variable}" format you will get "0" whenever a variable
is not defined, so whenever you do a comparison with a "<=" it will
resolve to TRUE when that variable is undefined.  Since fedora and
rhel are never both defined at the same time the above logic will
always resolve to being TRUE.
   Anytime you use this comparison logic to determine whether the
variable is "<="  you will also have to verify that the variable is
defined as well.

Thanks,
   Heath

On Fri, Oct 2, 2020 at 5:38 AM Craig Ringer
<[email protected]> wrote:
>
> Add a %dump at the end of the spec file body and/or relevant parts throughout to see how it evaluated. %echo macros are useful too
>
> On Fri, 2 Oct 2020, 17:08 Devrim Gündüz, <[email protected]> wrote:
>>
>>
>>
>> Hi,
>>
>> I am probably missing a very basic thing, but... What is wrong in this
>> line? I am expecting Fedora 32 and 33 not do depend on CGAL package,
>> but then the Fedora 33 RPM depends on CGAL >= 4.7 .
>>
>> https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/master/common/sfcgal/master/sfcg...
>>
>> What am I missing?
>>
>> Regards,
>> --
>> Devrim Gündüz
>> Open Source Solution Architect, Red Hat Certified Engineer
>> Twitter: @DevrimGunduz , @DevrimGunduzTR






^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2020-10-02 11:04 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-10-02 09:08 A basic spec file question Devrim Gündüz <[email protected]>
2020-10-02 09:37 ` Craig Ringer <[email protected]>
2020-10-02 11:04   ` Heath Lord <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox