public inbox for [email protected]  

help / color / mirror / Atom feed

From: John Harvey <[email protected]>
To: pgsql-pkg-yum <[email protected]>
Subject: Re: pgadmin4 RPM broken?
Date: Mon, 1 May 2017 08:15:03 -0400
Message-ID: <CABcP5fiHShZEJg6QSXcKkL=_tQt0_bSDWiH8V7VXgJSvMRuupA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CABcP5fjE3BmQVr_V91r=NcWUzjXVfdvneK=UGwixq-dCsthqXg@mail.gmail.com>
	<[email protected]>
	<CABcP5fhYPA-Ds74XW3WHBTr7SKL9G9i3bp4uOkyCCQPSecuTQw@mail.gmail.com>
	<[email protected]>
	<CABcP5fjGADmGE+C6krYo-bAQUv73gyo4JxsqXpWDuGJX+OvX=Q@mail.gmail.com>
	<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-pkg-yum>

Hi Devrim,

On Sun, Apr 30, 2017 at 4:35 AM, Devrim Gündüz <[email protected]> wrote:

>
> > I think that these lines should actually now be moved to:
> > Requires:       pgadmin4-python-itsdangerous >= 0.24
> >
> > Is that a correct assumption?
>
> I changed Python2 part only, and that was a great catch. Thanks!
>

It looks pretty good so far.  I think there's one last change needed based
on your most recent commit.
The line below appears to now be broken:

BuildRequires: python-itsdangerous >= 0.24 pgadmin4-python-flask-htmlmin

I think it should be:

BuildRequires: pgadmin4-python-itsdangerous >= 0.24
pgadmin4-python-flask-htmlmin

Without this change, I am unable to build on EL-7 since the base
python-itsdangerous package only goes up to 0.23.
However, if I make the above change, I can build successfully on EL-7.

The new spec file is in the repo now. Thanks for looking at this, it was
> great!


No problem.  Glad to help! :)

Regards,
  -John

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: pgadmin4 RPM broken?
  In-Reply-To: <CABcP5fiHShZEJg6QSXcKkL=_tQt0_bSDWiH8V7VXgJSvMRuupA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox