public inbox for [email protected]  

help / color / mirror / Atom feed
From: John Harvey <[email protected]>
To: pgsql-pkg-yum <[email protected]>
Subject: Re: pgadmin4 RPM broken?
Date: Mon, 8 May 2017 10:44:41 -0400
Message-ID: <CABcP5fjJEfaZdkJma5U-vj7c_wHMmtAmGyi=fvsZhnCJ7jwCVQ@mail.gmail.com> (raw)
In-Reply-To: <CABcP5fiHShZEJg6QSXcKkL=_tQt0_bSDWiH8V7VXgJSvMRuupA@mail.gmail.com>
References: <CABcP5fjE3BmQVr_V91r=NcWUzjXVfdvneK=UGwixq-dCsthqXg@mail.gmail.com>
	<[email protected]>
	<CABcP5fhYPA-Ds74XW3WHBTr7SKL9G9i3bp4uOkyCCQPSecuTQw@mail.gmail.com>
	<[email protected]>
	<CABcP5fjGADmGE+C6krYo-bAQUv73gyo4JxsqXpWDuGJX+OvX=Q@mail.gmail.com>
	<[email protected]>
	<CABcP5fiHShZEJg6QSXcKkL=_tQt0_bSDWiH8V7VXgJSvMRuupA@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-pkg-yum>

Hi Devrim,

It looks like all changes are in and work just fine.
I also can't reproduce my patch-file issues anymore, so that's good too!

I had one last finding today, based on your last set of commits from the
weekend.
I see that you've changed the python-flask dependencies in the pgadmin4
spec file to be pgadmin4-python-flask.

I have no issue with that change, but for consistency, you may want to
consider the following 2 modifications:

1) pgadmin4-python-flask-principal.spec

Change:
    Requires:      python-flask
to:
    Requires:      pgadmin4-python-flask

2) pgadmin4-python-flask-sqlalchemy.spec

Change:
    BuildRequires:  python-flask
to:
    BuildRequires:  pgadmin4-python-flask

Regards,
  -John


view thread (8+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: pgadmin4 RPM broken?
  In-Reply-To: <CABcP5fjJEfaZdkJma5U-vj7c_wHMmtAmGyi=fvsZhnCJ7jwCVQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox