pg.ddx.io  pgsql-rrreviewers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andy Colson <andy@squeakycode.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Cc: pgsql-rrreviewers@postgresql.org
Subject: Re: [HACKERS] reviewers needed!
Date: Sun, 16 Jan 2011 13:30:58 -0600
Message-ID: <4D334772.9070709@squeakycode.net> (raw)
In-Reply-To: <AANLkTinMrK=f7QDVfB8-KwWsCv-4a4ohbf4u4bHxvAjo@mail.gmail.com>
References: <AANLkTinMrK=f7QDVfB8-KwWsCv-4a4ohbf4u4bHxvAjo@mail.gmail.com>


I reviewed a couple patched, and I added my review to the commitfest page.

If I find a problem, its obvious I should mark the patch as "returned with feedback".

But what if I'm happy with it?  I'm not a hacker so cannot do C code review, should I leave it alone?  Mark it as "ready for committer"?


I marked my two reviews as ready for committer, but I feel like I've overstepped my bounds.

-Andy



view thread (14+ messages)  latest in thread

Message-ID: <4D334772.9070709@squeakycode.net>
Permalink:  ../4D334772.9070709@squeakycode.net/
Also on:    postgresql.org/message-id/4D334772.9070709@squeakycode.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-rrreviewers@postgresql.org
  Cc: andy@squeakycode.net, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: [HACKERS] reviewers needed!
  In-Reply-To: <4D334772.9070709@squeakycode.net>
  References: <AANLkTinMrK=f7QDVfB8-KwWsCv-4a4ohbf4u4bHxvAjo@mail.gmail.com> <4D334772.9070709@squeakycode.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox