pg.ddx.io  pgsql-rrreviewers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
Sign me up
3+ messages / 2 participants
[nested] [flat]

* Sign me up
@ 2011-11-14 21:17  Royce Ausburn <royce.ml@inomial.com>
  0 siblings, 1 reply; 3+ messages in thread

From: Royce Ausburn @ 2011-11-14 21:17 UTC (permalink / raw)
  To: pgsql-rrreviewers

Please give me the simpler patches -- I've been using pgsql for years, but only read some pgsql code a couple of months ago ;)  I'm not strong in C either, but I'll nut it out.






^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: Sign me up
@ 2011-11-15 01:52  Greg Smith <greg@2ndQuadrant.com>
  parent: Royce Ausburn <royce.ml@inomial.com>
  0 siblings, 1 reply; 3+ messages in thread

From: Greg Smith @ 2011-11-15 01:52 UTC (permalink / raw)
  To: pgsql-rrreviewers

On 11/14/2011 04:17 PM, Royce Ausburn wrote:
> Please give me the simpler patches -- I've been using pgsql for years, but only read some pgsql code a couple of months ago ;)  I'm not strong in C either, but I'll nut it out.
>    

How about "Include detailed information about a row failing a CHECK 
constraint into the error message"?  There's not a lot of code there, 
the main review work is preparing a test case that demonstrates the code 
does its job.  (One really should have been included with the patch, but 
this condition isn't difficult to recreate)  If that sounds reasonable, 
just edit the patch and add yourself there.  I see you've already 
created your own entry there, so you know how that works.

-- 
Greg Smith   2ndQuadrant US    greg@2ndQuadrant.com   Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support  www.2ndQuadrant.us




^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: Sign me up
@ 2011-11-15 02:15  Royce Ausburn <royce.ml@inomial.com>
  parent: Greg Smith <greg@2ndQuadrant.com>
  0 siblings, 0 replies; 3+ messages in thread

From: Royce Ausburn @ 2011-11-15 02:15 UTC (permalink / raw)
  To: Greg Smith <greg@2ndquadrant.com>; +Cc: pgsql-rrreviewers


On 15/11/2011, at 12:52 PM, Greg Smith wrote:

> On 11/14/2011 04:17 PM, Royce Ausburn wrote:
>> Please give me the simpler patches -- I've been using pgsql for years, but only read some pgsql code a couple of months ago ;)  I'm not strong in C either, but I'll nut it out.
>>   
> 
> How about "Include detailed information about a row failing a CHECK constraint into the error message"?  There's not a lot of code there, the main review work is preparing a test case that demonstrates the code does its job.  (One really should have been included with the patch, but this condition isn't difficult to recreate)  If that sounds reasonable, just edit the patch and add yourself there.  I see you've already created your own entry there, so you know how that works.

Thanks Greg.  I've added myself.  I'll review it in the next couple of days.


^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2011-11-15 02:15 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2011-11-14 21:17 Sign me up Royce Ausburn <royce.ml@inomial.com>
2011-11-15 01:52 ` Greg Smith <greg@2ndQuadrant.com>
2011-11-15 02:15   ` Royce Ausburn <royce.ml@inomial.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox