pg.ddx.io  pgsql-rrreviewers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Greg Smith <greg@2ndQuadrant.com>
To: pgsql-rrreviewers@postgresql.org
Subject: Re: Sign me up
Date: Mon, 14 Nov 2011 20:52:56 -0500
Message-ID: <4EC1C5F8.2030109@2ndQuadrant.com> (raw)
In-Reply-To: <76B1DD74-24D8-4F79-8720-0097701AC2E1@inomial.com>
References: <76B1DD74-24D8-4F79-8720-0097701AC2E1@inomial.com>

On 11/14/2011 04:17 PM, Royce Ausburn wrote:
> Please give me the simpler patches -- I've been using pgsql for years, but only read some pgsql code a couple of months ago ;)  I'm not strong in C either, but I'll nut it out.
>    

How about "Include detailed information about a row failing a CHECK 
constraint into the error message"?  There's not a lot of code there, 
the main review work is preparing a test case that demonstrates the code 
does its job.  (One really should have been included with the patch, but 
this condition isn't difficult to recreate)  If that sounds reasonable, 
just edit the patch and add yourself there.  I see you've already 
created your own entry there, so you know how that works.

-- 
Greg Smith   2ndQuadrant US    greg@2ndQuadrant.com   Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support  www.2ndQuadrant.us




view thread (3+ messages)  latest in thread

Message-ID: <4EC1C5F8.2030109@2ndQuadrant.com>
Permalink:  ../4EC1C5F8.2030109@2ndQuadrant.com/
Also on:    postgresql.org/message-id/4EC1C5F8.2030109@2ndQuadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-rrreviewers@postgresql.org
  Cc: greg@2ndQuadrant.com
  Subject: Re: Sign me up
  In-Reply-To: <4EC1C5F8.2030109@2ndQuadrant.com>
  References: <76B1DD74-24D8-4F79-8720-0097701AC2E1@inomial.com> <4EC1C5F8.2030109@2ndQuadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox