pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: mhh@mindspring.com
Cc: Joel Burton <jburton@scw.org>
Cc: pgsql-hackers@postgresql.org
Cc: pgsql-sql@postgresql.org
Subject: Re: [HACKERS] Re: Rules with Conditions: Bug, or Misunderstanding
Date: Fri, 01 Dec 2000 00:33:22 -0500
Message-ID: <1984.975648802@sss.pgh.pa.us> (raw)
In-Reply-To: <00113022072200.00743@jupiter.hollomon.fam>
References: <3A255246.21430.688927F3@localhost>
	<19579.975544973@sss.pgh.pa.us>
	<00113022072200.00743@jupiter.hollomon.fam>

Mark Hollomon <mhh@mindspring.com> writes:
> On Wednesday 29 November 2000 19:42, Tom Lane wrote:
>> Hm.  Perhaps the "cannot update view" test is too strict --- it's not
>> bright enough to realize that the two rules together cover all cases,
>> so it complains that you *might* be trying to update the view.  As the
>> code stands, you must provide an unconditional DO INSTEAD rule to
>> implement insertion or update of a view.

> It is in InitPlan, the same place we check to make sure that we are
> not changing a sequence or a toast table. (actually initResultRelInfo
> called from InitPlan). I gathered from the backend flowchart that this
> wasn't called until all rewriting was done. Was I wrong?

The rewriting is done, all right, but what's left afterward still has
references to the view, because each rule is conditional.  Essentially,
the rewriter output looks like

	-- rule 1
	if (rule1 condition holds)
		-- rule 2 applied to rule1 success case
		if (rule2 condition holds)
			apply rule 2's query
		else
			apply rule 1's query
	else
		-- rule 2 applied to rule1 failure case
		if (rule2 condition holds)
			apply rule 2's query
		else
			apply original query

If the system were capable of determining that either rule1 or rule2
condition will always hold, perhaps it could deduce that the original
query on the view will never be applied.  However, I doubt that we
really want to let loose an automated theorem prover on the results
of every rewrite ...

			regards, tom lane



view thread (11+ messages)  latest in thread

Message-ID: <1984.975648802@sss.pgh.pa.us>
Permalink:  ../1984.975648802@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1984.975648802@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-sql@postgresql.org
  Cc: tgl@sss.pgh.pa.us, mhh@mindspring.com, jburton@scw.org, pgsql-hackers@postgresql.org
  Subject: Re: [HACKERS] Re: Rules with Conditions: Bug, or Misunderstanding
  In-Reply-To: <1984.975648802@sss.pgh.pa.us>
  References: <3A255246.21430.688927F3@localhost> <19579.975544973@sss.pgh.pa.us> <00113022072200.00743@jupiter.hollomon.fam> <1984.975648802@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox