From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Don Baccus <dhogaza@pacifier.com>
Cc: Thomas Lockhart <lockhart@alumni.caltech.edu>
Cc: 'pgsql-sql@postgresql.org' <pgsql-sql@postgreSQL.org>
Cc: PostgreSQL Development <pgsql-hackers@postgreSQL.org>
Subject: Re: [HACKERS] Re: [SQL] prob with aggregate and group by - returns multiplesh
Date: Tue, 29 Feb 2000 12:21:26 -0500 (EST)
Message-ID: <200002291721.MAA26276@candle.pha.pa.us> (raw)
In-Reply-To: <29204.951840577@sss.pgh.pa.us>
Looks good to me.
> Don Baccus <dhogaza@pacifier.com> writes:
> > I vote for the SQL92 TEMPORARY. Let's not add a keyword that is non-standard
> > just because one or another commercial database makes use of it,
>
> You're missing the point: we are not talking about *adding* a keyword,
> we're talking about *removing* one that we've already supported for
> a year or so. That changes matters considerably, IMHO.
>
> I have in fact been able to make a conflict-free grammar in which TEMP
> is accepted but not reserved. It requires a certain amount of
> redundancy in the productions (see below), but I think this is a
> worthwhile tradeoff for not breaking existing user code.
>
> Shall I commit this?
>
> regards, tom lane
>
>
> /*
> * Redundancy here is needed to avoid shift/reduce conflicts,
> * since TEMP is not a reserved word. See also OptTemp.
> *
> * The result is a cons cell (not a true list!) containing
> * a boolean and a table name.
> */
> OptTempTableName: TEMPORARY opt_table relation_name
> { $$ = lcons(makeInteger(TRUE), (List *) $3); }
> | TEMP opt_table relation_name
> { $$ = lcons(makeInteger(TRUE), (List *) $3); }
> | LOCAL TEMPORARY opt_table relation_name
> { $$ = lcons(makeInteger(TRUE), (List *) $4); }
> | LOCAL TEMP opt_table relation_name
> { $$ = lcons(makeInteger(TRUE), (List *) $4); }
> | GLOBAL TEMPORARY opt_table relation_name
> {
> elog(ERROR, "GLOBAL TEMPORARY TABLE is not currently supported");
> $$ = lcons(makeInteger(TRUE), (List *) $4);
> }
> | GLOBAL TEMP opt_table relation_name
> {
> elog(ERROR, "GLOBAL TEMPORARY TABLE is not currently supported");
> $$ = lcons(makeInteger(TRUE), (List *) $4);
> }
> | TABLE relation_name
> { $$ = lcons(makeInteger(FALSE), (List *) $2); }
> | relation_name
> { $$ = lcons(makeInteger(FALSE), (List *) $1); }
> ;
>
--
Bruce Momjian | http://www.op.net/~candle
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-sql@postgresql.org
Cc: pgman@candle.pha.pa.us, tgl@sss.pgh.pa.us, dhogaza@pacifier.com, lockhart@alumni.caltech.edu, pgsql-hackers@postgreSQL.org
Subject: Re: [HACKERS] Re: [SQL] prob with aggregate and group by - returns multiplesh
In-Reply-To: <200002291721.MAA26276@candle.pha.pa.us>
References: <29204.951840577@sss.pgh.pa.us> <200002291721.MAA26276@candle.pha.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox