pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Hoffmann <jeff@propertykey.com>
Cc: pgsql-sql@postgresql.org
Subject: Re: RTREE on points
Date: Tue, 17 Apr 2001 14:01:22 -0400
Message-ID: <24852.987530482@sss.pgh.pa.us> (raw)
In-Reply-To: <3ADC7E8F.7569BABD@propertykey.com>
References: <9bbtqv$688$1@news.tht.net>
	<3ADAFF38.E7147C8D@propertykey.com>
	<008f01c0c68a$b6651c00$2285fd3e@julian>
	<3ADB65F4.6F83A1E7@propertykey.com>
	<19849.987464946@sss.pgh.pa.us>
	<3ADC6B1D.5C4C2D71@propertykey.com>
	<24276.987525349@sss.pgh.pa.us>
	<3ADC7E8F.7569BABD@propertykey.com>

Jeff Hoffmann <jeff@propertykey.com> writes:
> Tom Lane wrote:
>> How the heck did the GIST index code get developed/tested without some
>> opclasses?

> doing some digging at berkeley, i found the original pggist patch file
> that created the gist access method & gist_box_ops opclass (among
> others).  i'm assuming that patch was the basis for what was originally
> introduced, so i don't know why it didn't get included with everything
> else.

The CVS logs show there was some confusion about applying the whole of
the pggist patch, so it's possible that this was an unintentional
omission.

> it looks like there are a lot of calls to internal postgresql box
> comparison functions that would need to get converted to the new calling
> convention, but it should be pretty straightforward to get it to work
> with a recent version of postgresql.  it does seem pretty silly to have
> it in there if you don't have any built-in way of using it, if for no
> other reason than to be able to test if the feature even works. 

Yes.  I had been thinking of migrating one or more of the new contrib
GIST opclasses into the main distribution for 7.2, if only to be able to
create a regress test for GIST.  Updating this old Berkeley code would
be another path to create/extend a GIST regress test.  If you (or
someone else) have time to do that, it'd be great.

			regards, tom lane



view thread (13+ messages)  latest in thread

Message-ID: <24852.987530482@sss.pgh.pa.us>
Permalink:  ../24852.987530482@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/24852.987530482@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-sql@postgresql.org
  Cc: tgl@sss.pgh.pa.us, jeff@propertykey.com
  Subject: Re: RTREE on points
  In-Reply-To: <24852.987530482@sss.pgh.pa.us>
  References: <9bbtqv$688$1@news.tht.net> <3ADAFF38.E7147C8D@propertykey.com> <008f01c0c68a$b6651c00$2285fd3e@julian> <3ADB65F4.6F83A1E7@propertykey.com> <19849.987464946@sss.pgh.pa.us> <3ADC6B1D.5C4C2D71@propertykey.com> <24276.987525349@sss.pgh.pa.us> <3ADC7E8F.7569BABD@propertykey.com> <24852.987530482@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox