From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Lockhart <lockhart@alumni.caltech.edu>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: [HACKERS] Re: missing function datetime()
Date: Mon, 28 Feb 2000 11:26:35 -0500
Message-ID: <25673.951755195@sss.pgh.pa.us> (raw)
In-Reply-To: <38BAA1C2.65971352@alumni.caltech.edu>
References: <Pine.LNX.4.21.0002241604480.17558-100000@net-srv-0001.bvrd.com>
<23337.951436670@sss.pgh.pa.us>
<006e01bf7f81$b9a91d40$760e01a3@oucs.ox.ac.uk>
<7619.951496583@sss.pgh.pa.us>
<38BAA1C2.65971352@alumni.caltech.edu>
Thomas Lockhart <lockhart@alumni.caltech.edu> writes:
>> I can see two ways to do that: either add another function to pg_proc
>> (five of them actually :-(), or hack the parser to translate a function
>> name 'datetime' to 'timestamp'. Ugly as the second one sounds, it has
>> a couple of advantages.
> xlateSqlFunc() is already in gram.y; enjoy...
Will do, just wanted to see if you approved or not.
When you finish catching up on the back email, I'd like to know what
you think about the question of comment lexing. Should we change scan.l
so that it will recognize /* or -- as comment starters even if they are
embedded in what would currently be considered a long operator token?
If so, is it OK to depend on yyless() to do it, or is that a flex-ism?
I'd also kind of like to put in a test to detect unterminated comments
and literals. The flex manual recommends <<EOF>> but that only works
in flex. I was speculating that a rule for <xq> followed by nothing
might work, if all the other <xq> rules match at least one character.
Thoughts?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-sql@postgresql.org
Cc: tgl@sss.pgh.pa.us, lockhart@alumni.caltech.edu, pgsql-hackers@postgreSQL.org
Subject: Re: [HACKERS] Re: missing function datetime()
In-Reply-To: <25673.951755195@sss.pgh.pa.us>
References: <Pine.LNX.4.21.0002241604480.17558-100000@net-srv-0001.bvrd.com> <23337.951436670@sss.pgh.pa.us> <006e01bf7f81$b9a91d40$760e01a3@oucs.ox.ac.uk> <7619.951496583@sss.pgh.pa.us> <38BAA1C2.65971352@alumni.caltech.edu> <25673.951755195@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox