pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: Marcin Kowalski <kowalski@datrix.co.za>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP
Date: Sat, 31 Mar 2001 19:53:39 -0500
Message-ID: <28177.986086419@sss.pgh.pa.us> (raw)
In-Reply-To: <200103310114.UAA13928@candle.pha.pa.us>
References: <200103310114.UAA13928@candle.pha.pa.us>

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> First, here is a patch which will prevent this from happening in the
> future.  Do people want this held for 7.2 or applied now?  It disables
> the creation of user indexes on system tables.
  
> + 	if (heapRelationName && !allow_system_table_mods &&
> + 		IsSystemRelationName(heapRelationName) && IsNormalProcessingMode())
> + 	{
> + 		elog(ERROR, "You can not create indexes on system tables:  '%s'",
> + 			 heapRelationName);
> + 	}
> + 

I think it would be a real good idea to put in this safeguard, but
I don't much like that error message.  How about

    elog(ERROR, "User-defined indexes on system catalogs are not supported");


			regards, tom lane



view thread (9+ messages)  latest in thread

Message-ID: <28177.986086419@sss.pgh.pa.us>
Permalink:  ../28177.986086419@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/28177.986086419@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-sql@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgman@candle.pha.pa.us, kowalski@datrix.co.za, pgsql-hackers@postgresql.org
  Subject: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP
  In-Reply-To: <28177.986086419@sss.pgh.pa.us>
  References: <200103310114.UAA13928@candle.pha.pa.us> <28177.986086419@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox