pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas G. Lockhart <lockhart@alumni.caltech.edu>
To: Bruce Momjian <maillist@candle.pha.pa.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-sql@hub.org
Subject: Re: [SQL] char type seems the same as char(1)
Date: Mon, 14 Dec 1998 00:24:41 +0000
Message-ID: <36745AC9.3EF6DB74@alumni.caltech.edu> (raw)
References: <199812131931.OAA01559@candle.pha.pa.us>

> > Well, Tom Lockhart responded that "it's not a bug, it's a feature".
> > I still think it's broken --- and certainly the fact that quoting
> > affects the result (char and "char" act differently) is not good.

OK, I've committed changes to *both* trees prompted by the problems with
handling the single-byte character type.

One set of changes removes the double quotes from most data type fields
in pg_dump (they aren't really legal there in the SQL92 sense anyway).
pg_dump now writes "character" and "character varying" for the Postgres
internal types "bpchar" and "varchar" to be more compatible with
standard usage.

Another set of changes modifies the type matching for DEFAULT statements
to use the recently implemented implicit type coersion techniques. More
permutations of DEFAULT clauses should now be legal and handled.

Please test this stuff! Especially if you are set up to test the REL6_4
tree since I've done all testing on the main development tree.

btw, all regression tests pass on my machine.

> If we use char1 for internal tables, we should allow it externally, if
> only as char1.  I will add it to the TODO list.

As what?

                     - Tom



view thread (9+ messages)  latest in thread

Message-ID: <36745AC9.3EF6DB74@alumni.caltech.edu>
Permalink:  ../36745AC9.3EF6DB74@alumni.caltech.edu/
Also on:    postgresql.org/message-id/36745AC9.3EF6DB74@alumni.caltech.edu

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-sql@postgresql.org
  Cc: lockhart@alumni.caltech.edu, maillist@candle.pha.pa.us, tgl@sss.pgh.pa.us, pgsql-sql@hub.org
  Subject: Re: [SQL] char type seems the same as char(1)
  In-Reply-To: <36745AC9.3EF6DB74@alumni.caltech.edu>
  References: <199812131931.OAA01559@candle.pha.pa.us> <36745AC9.3EF6DB74@alumni.caltech.edu>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox