pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Josh Berkus <josh@agliodbs.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: sqllist <pgsql-sql@postgresql.org>
Cc: Jan Wieck <JanWieck@Yahoo.com>
Subject: Re: Huh? Mysterious Function Error
Date: Tue, 20 Feb 2001 09:58:09 -0800
Message-ID: <3A92B031.B2B6119B@agliodbs.com> (raw)
References: <3A92A15E.1E7DF00D@agliodbs.com>
	<15771.982690612@sss.pgh.pa.us>

Tom, Stephan,

> Josh Berkus <josh@agliodbs.com> writes:
> > ERROR:  unexpected SELECT query in exec_stmt_execsql()
> 
> plpgsql doesn't think you should execute bare SELECTs, only SELECT INTO.

That would explain it.  I have a nested function call in the form:

SELECT fn_remove_lock(record_id, user_id);

Because  I didn't care what the function returned and SELECT is the
simplest form.  Easily fixed.

> 
> On reflection this seems an overly anal-retentive restriction, since
> there are cases where one might execute a SELECT for its side effects
> alone ("SELECT setval()" comes to mind).

> Jan, do you think there's a good case for refusing plain SELECTs?

I can think of one, myself.  In some systems (MS SQL Server), all plain
selects are returned by stored procedures as query results; thus a
stored procedure is able to return multiple rowsets.  In other systems,
the single returned rowset is given by the last palin SELECT in the
procedure.

Thus, until PGSQL *does* support stored procedures, refusing plain
SELECTs may be a good way to remind procedure-writers that we do not
have the ability to return rowsets.

For stuff like my procedure, or Tom's example, one can always designate
a dummy variable with:

dummy_variable := setval('some_sq',321);

Which should have the same effect.

-Josh Berkus


-- 
______AGLIO DATABASE SOLUTIONS___________________________
                                        Josh Berkus
   Complete information technology      josh@agliodbs.com
    and data management solutions       (415) 565-7293
   for law firms, small businesses       fax  621-2533
    and non-profit organizations.       San Francisco



view thread (4+ messages)

Message-ID: <3A92B031.B2B6119B@agliodbs.com>
Permalink:  ../3A92B031.B2B6119B@agliodbs.com/
Also on:    postgresql.org/message-id/3A92B031.B2B6119B@agliodbs.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-sql@postgresql.org
  Cc: josh@agliodbs.com, tgl@sss.pgh.pa.us, JanWieck@Yahoo.com
  Subject: Re: Huh? Mysterious Function Error
  In-Reply-To: <3A92B031.B2B6119B@agliodbs.com>
  References: <3A92A15E.1E7DF00D@agliodbs.com> <15771.982690612@sss.pgh.pa.us> <3A92B031.B2B6119B@agliodbs.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox