pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Oleg Bartunov <oleg@sai.msu.su>
To: Vadim Mikheev <vadim@krs.ru>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgreSQL.org
Cc: pgsql-sql@postgreSQL.org
Subject: Re: [SQL] inserts/updates problem under stressing !
Date: Mon, 26 Jul 1999 10:49:11 +0400 (MSD)
Message-ID: <Pine.GSO.3.96.SK.990726103105.10884D-100000@ra> (raw)
In-Reply-To: <379BFF7E.BD57269E@krs.ru>

On Mon, 26 Jul 1999, Vadim Mikheev wrote:

> Date: Mon, 26 Jul 1999 14:26:06 +0800
> From: Vadim Mikheev <vadim@krs.ru>
> To: Oleg Bartunov <oleg@sai.msu.su>
> Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgreSQL.org,
>     pgsql-sql@postgreSQL.org
> Subject: Re: [SQL] inserts/updates problem under stressing !
> 
> Oleg Bartunov wrote:
> > 
> > >
> > > SELECT FOR UPDATE will not help: if there was no record for
> > > particular key then nothing will be locked and two records with
> > > the same key will be inserted.
> > >
> > > Oleg, use LOCK IN SHARE ROW EXCLUSIVE MODE.
> > 
> > Thanks Vadim. Just tried this, but still I see a difference between
> > count hits (accumulated) from db and access_log. In my test these numbers are:
> > 95 and 109. So I lost 14 hits ! And no errors !
> > In my handler I have now:
> > 
> > my $sth = $dbh->do("LOCK TABLE hits IN SHARE ROW EXCLUSIVE MODE");
> > my $sth = $dbh->do("SELECT acc_hits($1)") || die $dbh->errstr;
> > 
> > am I right ?
> 
> You should run LOCK and SELECT inside BEGIN/END (i.e. in
> the same transaction), do you?

Good question.

I use perl DBI interface to work with postgres and I supposed it does
transaction automatically.  Will check it.
Aha, got the problem. Now everything works !!!

	Tnanks again,

		Oleg

So, here is a working handler to *accumulate* hit statistics.

package Apache::HitsDBI;
use Apache::Constants qw(:common);

use strict;
# preloaded in startup.pl
#use DBI ();

sub handler {
    my $orig = shift;
    my $url  = $orig->uri;
    if ( $orig->args() =~ /msg_id=(\d+)/ ) {
      my $dbh = DBI->connect("dbi:Pg:dbname=discovery") || die DBI->errstr;
      $dbh->{AutoCommit} = 0;
      my $sth = $dbh->do("LOCK TABLE hits IN SHARE ROW EXCLUSIVE MODE") || die $dbh->errstr;
      my $sth = $dbh->do("SELECT acc_hits($1)") || die $dbh->errstr;
      my $rc  = $dbh->commit     || die $dbh->errstr;
    }
    return OK;
}

1;
__END__



	Oleg
> 
> Vadim
> 

_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83




view thread (11+ messages)  latest in thread

Message-ID: <Pine.GSO.3.96.SK.990726103105.10884D-100000@ra>
Permalink:  ../Pine.GSO.3.96.SK.990726103105.10884D-100000@ra/
Also on:    postgresql.org/message-id/Pine.GSO.3.96.SK.990726103105.10884D-100000@ra

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-sql@postgresql.org
  Cc: oleg@sai.msu.su, vadim@krs.ru, tgl@sss.pgh.pa.us, pgsql-hackers@postgreSQL.org
  Subject: Re: [SQL] inserts/updates problem under stressing !
  In-Reply-To: <Pine.GSO.3.96.SK.990726103105.10884D-100000@ra>
  References: <379BFF7E.BD57269E@krs.ru> <Pine.GSO.3.96.SK.990726103105.10884D-100000@ra>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox