From: Rajesh Kumar Mallah <mallah.rajesh@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-sql@postgresql.org
Subject: Re: calling elog possibly causing problem in DirectFunctionCall1
Date: Sat, 2 Dec 2006 00:28:02 +0530
Message-ID: <a97c77030612011058q513d02baofb496fd2ea7fa1c6@mail.gmail.com> (raw)
In-Reply-To: <628.1164995263@sss.pgh.pa.us>
References: <a97c77030612010840o3436b7bcje1cdfc507c009f3b@mail.gmail.com>
<628.1164995263@sss.pgh.pa.us>
On 12/1/06, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> "Rajesh Kumar Mallah" <mallah.rajesh@gmail.com> writes:
> > data->time_stamp =
> > DirectFunctionCall1(timestamptz_in, CStringGetDatum("now"));
>
> This code is incorrect, as timestamptz_in takes three arguments.
replaced it with:
data->time_stamp = DirectFunctionCall3(timestamptz_in,
CStringGetDatum("now"),
ObjectIdGetDatum(InvalidOid),
Int32GetDatum(-1))
now it works fine. (code lifted from contrib/spi/moddatetime.c(line 73)
hopefully its correct.
regards, tom lane
>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-sql@postgresql.org
Cc: mallah.rajesh@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: calling elog possibly causing problem in DirectFunctionCall1
In-Reply-To: <a97c77030612011058q513d02baofb496fd2ea7fa1c6@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox