pg.ddx.io  pgsql-students@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <hlinnakangas@vmware.com>
To: Stas Kelvich <stas.kelvich@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: pgsql-students@postgresql.org
Subject: Re: [HACKERS] Cube extension point support // GSoC'13
Date: Mon, 16 Sep 2013 09:48:28 +0300
Message-ID: <5236A9BC.3030000@vmware.com> (raw)
In-Reply-To: <23364502-F542-4553-A658-4D3A2B6FCFA9@gmail.com>
References: <23364502-F542-4553-A658-4D3A2B6FCFA9@gmail.com>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-students>

On 12.07.2013 14:57, Stas Kelvich wrote:
> Hello.
>
> here is a patch adding to cube extension support for compressed representation of point cubes. If cube is a point, i.e. has coincident lower left and upper right corners, than only one corner is stored. First bit of the cube header indicates whether the cube is point or not. Few moments:
>
> * Patch preserves binary compatibility with old indices
> * All functions that create cubes from user input, check whether it is a point or not
> * All internal functions that can return cubes takes care of all cases where a cube might become a point

Great!

cube_is_point() needs to still handle old-style points. An NDBOX without 
the point-flag set, where the ll and ur coordinates for each dimension 
are the same, still needs to be considered a point. Even if you are 
careful to never construct such structs in the code, they can be present 
on-disk if you have upgraded from an earlier version with pg_upgrade. 
Same in cube_out().

> * Added tests for checking correct point behavior

You'll need to adjust all the expected output files, not only cube_1.out.

> Also this patch includes adapted Alexander Korotkov's patch with kNN-based ordering operator, which he wrote for postgresql-9.0beta1 with knngist patch. More info there http://www.postgresql.org/message-id/AANLkTimhFaq6hCibRnk0tlcQMIyhYWHwAQ2ZD87wbH86@mail.gmail.com

To make review easier, it would be better to keep that as a separate 
patch, actually. Could you split it up again, please?

- Heikki


-- 
Sent via pgsql-students mailing list (pgsql-students@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-students



view thread (12+ messages)  latest in thread

Message-ID: <5236A9BC.3030000@vmware.com>
Permalink:  ../5236A9BC.3030000@vmware.com/
Also on:    postgresql.org/message-id/5236A9BC.3030000@vmware.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-students@postgresql.org
  Cc: hlinnakangas@vmware.com, stas.kelvich@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: [HACKERS] Cube extension point support // GSoC'13
  In-Reply-To: <5236A9BC.3030000@vmware.com>
  References: <23364502-F542-4553-A658-4D3A2B6FCFA9@gmail.com> <5236A9BC.3030000@vmware.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox