pg.ddx.io  pgsql-testers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
Cc: oleg@sai.msu.su, Denis de Bernardy <ddebernardy@yahoo.com>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Cc: pgsql-bugs@postgresql.org
Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)
Date: Sat, 02 Jul 2011 18:38:53 -0400
Message-ID: <21086.1309646333@sss.pgh.pa.us> (raw)
In-Reply-To: <1308504190.2597.71.camel@jdavis>
References: <4DF81BA0.3000601@archidevsys.co.nz>
	<743036.48052.qm@web112401.mail.gq1.yahoo.com>
	<366790.65150.qm@web112414.mail.gq1.yahoo.com>
	<BANLkTikm9Q_z1aYCB9U_Pc0tPTO+LzG57Q@mail.gmail.com>
	<1308428403.2597.66.camel@jdavis>
	<1308504190.2597.71.camel@jdavis>

Jeff Davis <pgsql@j-davis.com> writes:
> On Sat, 2011-06-18 at 13:20 -0700, Jeff Davis wrote:
>> Interesting problem... the bug is in get_op_btree_interpretation() which
>> has code like this:
>> ...
>> However, that's a bogus test, because btree_gist puts <> into an
>> opfamily. Thus, catlist->n_members == 1 even though we really do need to
>> look for the negator. Really, we need to unconditionally search for the
>> operator as well as unconditionally searching for the negator.

> Patch attached.

I looked at this a bit.  The proposed patch is inadequate, aside from
any excess lookups it introduces, because there is similar logic in
predtest.c.  To make the world safe for btree_gist to do this, we'd have
to add extra lookup activity there as well.

Quite honestly, I think that the bug is that btree_gist took it upon
itself to invent <> as an indexable operator.  The odds that that will
ever be of practical use seem negligible, and not at all adequate to
warrant adding extra cycles into mainstream code paths.  It's not too
late to rip that out of 9.1, and that's what I think we should do.

			regards, tom lane



view thread (10+ messages)  latest in thread

Message-ID: <21086.1309646333@sss.pgh.pa.us>
Permalink:  ../21086.1309646333@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/21086.1309646333@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-testers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql@j-davis.com, ddebernardy@yahoo.com, teodor@sigaev.ru, pgsql-bugs@postgresql.org
  Subject: Re: PG regression with row comparison when btree_gist is enabled (BUG)
  In-Reply-To: <21086.1309646333@sss.pgh.pa.us>
  References: <4DF81BA0.3000601@archidevsys.co.nz> <743036.48052.qm@web112401.mail.gq1.yahoo.com> <366790.65150.qm@web112414.mail.gq1.yahoo.com> <BANLkTikm9Q_z1aYCB9U_Pc0tPTO+LzG57Q@mail.gmail.com> <1308428403.2597.66.camel@jdavis> <1308504190.2597.71.camel@jdavis> <21086.1309646333@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox