pg.ddx.io  pgsql-testers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
Cc: oleg@sai.msu.su, Denis de Bernardy <ddebernardy@yahoo.com>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Cc: pgsql-bugs@postgresql.org
Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)
Date: Wed, 06 Jul 2011 14:59:47 -0400
Message-ID: <24699.1309978787@sss.pgh.pa.us> (raw)
In-Reply-To: <1309975571.3012.141.camel@jdavis>
References: <4DF81BA0.3000601@archidevsys.co.nz>
	<743036.48052.qm@web112401.mail.gq1.yahoo.com>
	<366790.65150.qm@web112414.mail.gq1.yahoo.com>
	<BANLkTikm9Q_z1aYCB9U_Pc0tPTO+LzG57Q@mail.gmail.com>
	<1308428403.2597.66.camel@jdavis>
	<1308504190.2597.71.camel@jdavis>
	<21086.1309646333@sss.pgh.pa.us>
	<1309886656.3012.83.camel@jdavis>
	<21432.1309888581@sss.pgh.pa.us>
	<1309971611.3012.121.camel@jdavis>
	<13404.1309973153@sss.pgh.pa.us>
	<1309975571.3012.141.camel@jdavis>

Jeff Davis <pgsql@j-davis.com> writes:
> On Wed, 2011-07-06 at 13:25 -0400, Tom Lane wrote:
>> Actually, I'd just been working on this myself.  I think the cleanest
>> solution will be to get rid of the duplicative logic by making
>> predtest.c use get_op_btree_interpretation().  That will require
>> changing get_op_btree_interpretation() so it can return amoplefttype
>> and amoprighttype too, but given the small number of callers, an API
>> change for it doesn't seem like a problem.

> Sounds good to me.

Committed that way.  Just for the archives' sake, the test case I was
using for the planner side of things was

create index tenk1p on tenk1 (twothousand) where twothousand <> 42;
explain select * from tenk1 where twothousand < 40;

which should use the partial index, but it was failing to prove the
implication when btree_gist was installed.

			regards, tom lane



view thread (10+ messages)

Message-ID: <24699.1309978787@sss.pgh.pa.us>
Permalink:  ../24699.1309978787@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/24699.1309978787@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-testers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql@j-davis.com, ddebernardy@yahoo.com, teodor@sigaev.ru, pgsql-bugs@postgresql.org
  Subject: Re: PG regression with row comparison when btree_gist is enabled (BUG)
  In-Reply-To: <24699.1309978787@sss.pgh.pa.us>
  References: <4DF81BA0.3000601@archidevsys.co.nz> <743036.48052.qm@web112401.mail.gq1.yahoo.com> <366790.65150.qm@web112414.mail.gq1.yahoo.com> <BANLkTikm9Q_z1aYCB9U_Pc0tPTO+LzG57Q@mail.gmail.com> <1308428403.2597.66.camel@jdavis> <1308504190.2597.71.camel@jdavis> <21086.1309646333@sss.pgh.pa.us> <1309886656.3012.83.camel@jdavis> <21432.1309888581@sss.pgh.pa.us> <1309971611.3012.121.camel@jdavis> <13404.1309973153@sss.pgh.pa.us> <1309975571.3012.141.camel@jdavis> <24699.1309978787@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox