pg.ddx.io pgsql-testers@postgresql.org mailing list archive
help / color / mirror / Atom feed9.0Beta2 Build on Mac (64 bit) of pg_upgrade fails with duplicate symbols
4+ messages / 3 participants
[nested] [flat]
* 9.0Beta2 Build on Mac (64 bit) of pg_upgrade fails with duplicate symbols
@ 2010-06-09 19:03 Chris Ruprecht <chrrup@gmail.com>
0 siblings, 2 replies; 4+ messages in thread
From: Chris Ruprecht @ 2010-06-09 19:03 UTC (permalink / raw)
To: pgsql-testers
I'm building the contrib modules and get this:
gcc -no-cpp-precomp -O3 -fno-common -arch x86_64 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv check.o controldata.o dump.o exec.o file.o function.o info.o option.o page.o pg_upgrade.o relfilenode.o server.o tablespace.o util.o version.o version_old_8_3.o -L../../src/port -lpgport -L../../src/interfaces/libpq -lpq -L../../src/port -O3 -fno-common -arch x86_64 -Wl,-dead_strip_dylibs -lpgport -lpam -lssl -lcrypto -lgssapi_krb5 -lz -lreadline -lm -o pg_upgrade
ld: duplicate symbol _scandir_file_pattern in controldata.o and check.o
My configure script looks like:
export MACOSX_DEPLOYMENT_TARGET=10.6
export CC=gcc
export CPP="gcc -E"
export CXX=g++
export CXXFLAGS='-O3 -fno-common -arch x86_64'
export CFLAGS='-O3 -fno-common -arch x86_64'
export LDFLAGS='-O3 -fno-common -arch x86_64'
./configure \
--prefix=/usr \
--enable-integer-datetimes \
--with-tcl \
--with-perl \
--with-python \
--with-gssapi \
--with-krb5 \
--with-pam \
--with-ldap \
--with-bonjour \
--with-openssl \
--with-zlib
make of the normal sources worked.
But
cd contrib
make
resulted in the error above.
best regards,
chris
--
chris ruprecht
specialist in obscure details
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: 9.0Beta2 Build on Mac (64 bit) of pg_upgrade fails with duplicate symbols
@ 2010-06-14 23:00 Josh Berkus <josh@agliodbs.com>
parent: Chris Ruprecht <chrrup@gmail.com>
1 sibling, 0 replies; 4+ messages in thread
From: Josh Berkus @ 2010-06-14 23:00 UTC (permalink / raw)
To: Chris Ruprecht <chrrup@gmail.com>; +Cc: pgsql-testers
> make of the normal sources worked.
> But
> cd contrib
> make
> resulted in the error above.
cd contrib, or cd contrib/pg_upgrade?
--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: 9.0Beta2 Build on Mac (64 bit) of pg_upgrade fails with duplicate symbols
@ 2010-06-15 02:12 Bruce Momjian <bruce@momjian.us>
parent: Chris Ruprecht <chrrup@gmail.com>
1 sibling, 1 reply; 4+ messages in thread
From: Bruce Momjian @ 2010-06-15 02:12 UTC (permalink / raw)
To: Chris Ruprecht <chrrup@gmail.com>; +Cc: pgsql-testers
Chris Ruprecht wrote:
> I'm building the contrib modules and get this:
>
> gcc -no-cpp-precomp -O3 -fno-common -arch x86_64 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv check.o controldata.o dump.o exec.o file.o function.o info.o option.o page.o pg_upgrade.o relfilenode.o server.o tablespace.o util.o version.o version_old_8_3.o -L../../src/port -lpgport -L../../src/interfaces/libpq -lpq -L../../src/port -O3 -fno-common -arch x86_64 -Wl,-dead_strip_dylibs -lpgport -lpam -lssl -lcrypto -lgssapi_krb5 -lz -lreadline -lm -o pg_upgrade
> ld: duplicate symbol _scandir_file_pattern in controldata.o and check.o
Oops. That global variable was not properly defined; not sure why none
of the other compilers caught that bug. Anyway, the attached patch
should fix your problem, and will appear in 9.0 beta3. Thanks for the
report.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ None of us is going to be here forever. +
Attachments:
/rtmp/diff (text/x-diff, 1.2K) download
Index: contrib/pg_upgrade/pg_upgrade.h
===================================================================
RCS file: /cvsroot/pgsql/contrib/pg_upgrade/pg_upgrade.h,v
retrieving revision 1.7
diff -c -c -r1.7 pg_upgrade.h
*** contrib/pg_upgrade/pg_upgrade.h 12 Jun 2010 17:45:28 -0000 1.7
--- contrib/pg_upgrade/pg_upgrade.h 15 Jun 2010 02:01:48 -0000
***************
*** 237,243 ****
/*
* Global variables
*/
! char scandir_file_pattern[MAXPGPATH];
/* check.c */
--- 237,243 ----
/*
* Global variables
*/
! extern char scandir_file_pattern[];
/* check.c */
Index: contrib/pg_upgrade/relfilenode.c
===================================================================
RCS file: /cvsroot/pgsql/contrib/pg_upgrade/relfilenode.c,v
retrieving revision 1.3
diff -c -c -r1.3 relfilenode.c
*** contrib/pg_upgrade/relfilenode.c 13 May 2010 22:51:00 -0000 1.3
--- contrib/pg_upgrade/relfilenode.c 15 Jun 2010 02:01:48 -0000
***************
*** 17,22 ****
--- 17,25 ----
const char *oldnspname, const char *oldrelname,
const char *newnspname, const char *newrelname);
+ /* used by scandir(), must be global */
+ char scandir_file_pattern[MAXPGPATH];
+
/*
* transfer_all_new_dbs()
*
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: 9.0Beta2 Build on Mac (64 bit) of pg_upgrade fails with duplicate symbols
@ 2010-06-15 07:13 Chris Ruprecht <chrrup@gmail.com>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 4+ messages in thread
From: Chris Ruprecht @ 2010-06-15 07:13 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; Josh Berkus <josh@agliodbs.com>; +Cc: pgsql-testers
Sorry for the late reply Josh, but apparently, Bruce already has a fix for the issue - Thanks Bruce!!
Thanks a bunch, I'll put the patch in when I get back home on Saturday.
.... if only my commercial RDBMS provider had turn-around times like you guys ....
best regards,
chris
--
chris ruprecht
specialist in obscure details
On Jun 14, 2010, at 22:12 , Bruce Momjian wrote:
> Chris Ruprecht wrote:
>> I'm building the contrib modules and get this:
>>
>> gcc -no-cpp-precomp -O3 -fno-common -arch x86_64 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv check.o controldata.o dump.o exec.o file.o function.o info.o option.o page.o pg_upgrade.o relfilenode.o server.o tablespace.o util.o version.o version_old_8_3.o -L../../src/port -lpgport -L../../src/interfaces/libpq -lpq -L../../src/port -O3 -fno-common -arch x86_64 -Wl,-dead_strip_dylibs -lpgport -lpam -lssl -lcrypto -lgssapi_krb5 -lz -lreadline -lm -o pg_upgrade
>> ld: duplicate symbol _scandir_file_pattern in controldata.o and check.o
>
> Oops. That global variable was not properly defined; not sure why none
> of the other compilers caught that bug. Anyway, the attached patch
> should fix your problem, and will appear in 9.0 beta3. Thanks for the
> report.
>
> --
> Bruce Momjian <bruce@momjian.us> http://momjian.us
> EnterpriseDB http://enterprisedb.com
>
> + None of us is going to be here forever. +
> Index: contrib/pg_upgrade/pg_upgrade.h
> ===================================================================
> RCS file: /cvsroot/pgsql/contrib/pg_upgrade/pg_upgrade.h,v
> retrieving revision 1.7
> diff -c -c -r1.7 pg_upgrade.h
> *** contrib/pg_upgrade/pg_upgrade.h 12 Jun 2010 17:45:28 -0000 1.7
> --- contrib/pg_upgrade/pg_upgrade.h 15 Jun 2010 02:01:48 -0000
> ***************
> *** 237,243 ****
> /*
> * Global variables
> */
> ! char scandir_file_pattern[MAXPGPATH];
>
>
> /* check.c */
> --- 237,243 ----
> /*
> * Global variables
> */
> ! extern char scandir_file_pattern[];
>
>
> /* check.c */
> Index: contrib/pg_upgrade/relfilenode.c
> ===================================================================
> RCS file: /cvsroot/pgsql/contrib/pg_upgrade/relfilenode.c,v
> retrieving revision 1.3
> diff -c -c -r1.3 relfilenode.c
> *** contrib/pg_upgrade/relfilenode.c 13 May 2010 22:51:00 -0000 1.3
> --- contrib/pg_upgrade/relfilenode.c 15 Jun 2010 02:01:48 -0000
> ***************
> *** 17,22 ****
> --- 17,25 ----
> const char *oldnspname, const char *oldrelname,
> const char *newnspname, const char *newrelname);
>
> + /* used by scandir(), must be global */
> + char scandir_file_pattern[MAXPGPATH];
> +
> /*
> * transfer_all_new_dbs()
> *
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2010-06-15 07:13 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2010-06-09 19:03 9.0Beta2 Build on Mac (64 bit) of pg_upgrade fails with duplicate symbols Chris Ruprecht <chrrup@gmail.com>
2010-06-14 23:00 ` Josh Berkus <josh@agliodbs.com>
2010-06-15 02:12 ` Bruce Momjian <bruce@momjian.us>
2010-06-15 07:13 ` Chris Ruprecht <chrrup@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox